Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add REVIEWER @pavelkalinnikov #87

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Add REVIEWER @pavelkalinnikov #87

merged 1 commit into from
Jul 21, 2023

Conversation

tbg
Copy link
Collaborator

@tbg tbg commented Jul 21, 2023

As discussion in #59.

Signed-off-by: Tobias Grieger tobias.b.grieger@gmail.com

@tbg
Add REVIEWER @pavelkalinnikov
fe7caf3 
As discussion in etcd-io#59.

Signed-off-by: Tobias Grieger <tobias.b.grieger@gmail.com>
@ahrtr ahrtr marked this pull request as ready for review July 21, 2023 13:30
@tbg tbg requested a review from ahrtr July 21, 2023 13:30
ahrtr
ahrtr approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as we already discussed and agreed in #59.

Thanks @tbg for the followup, and Congratulation @pavelkalinnikov

cc @spzala @ptabor @serathius

@tbg
Copy link
Collaborator Author

tbg commented Jul 21, 2023

Merging since this is approved by @ahrtr and @tbg and so we have quorum of maintainers. Additionally, #59 has support by @spzala.

Thanks all!

@tbg tbg merged commit ff1a64f into etcd-io:main Jul 21, 2023
7 checks passed
@tbg tbg deleted the pavel-review branch July 21, 2023 13:57
@ahrtr ahrtr mentioned this pull request Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbg @ahrtr