Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline link-checking build config and commands #456

Merged
merged 2 commits into from
Aug 19, 2021
Merged

Streamline link-checking build config and commands #456

merged 2 commits into from
Aug 19, 2021

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Aug 19, 2021 •
edited
Loading

  • Use --skip-external flag instead of having two htmltest config files.
  • As necessary, build htmltest from source so that we have the latest features!
    • Once build,htmltest will be reused (rather than refetched & rebuilt).
  • Ignore /docs/latest so that we no longer need to setup symlinks

If you've previously run the link checker scripts, you'll first need to delete the HTMLTEST directory before running the link checking scripts again. To do this run this command:

# From your etcd.io website repo directory
$ rm -Rf tmp

@chalin chalin added the infrastructure Categorizes issue or PR as related to site infrastructure. label Aug 19, 2021
@chalin chalin requested a review from nate-double-u August 19, 2021 20:24
@chalin chalin changed the title Streamline link checking build config and commands Streamline link-checking build config and commands Aug 19, 2021
@chalin chalin force-pushed the chalin-check-links-2021-08-19 branch 2 times, most recently from a2561e0 to 42e98ac Compare August 19, 2021 20:50
@chalin chalin force-pushed the chalin-check-links-2021-08-19 branch from 42e98ac to 618f4c6 Compare August 19, 2021 20:54
nate-double-u
nate-double-u approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tested on Ubuntu.

The npm run check-links:all throws errors that it probably shouldn't but I think that's outside of the scope of this PR, and reflects that we likely need to revisit external link checking as a separate issue.

@nate-double-u nate-double-u merged commit 5763f19 into main Aug 19, 2021
@chalin chalin deleted the chalin-check-links-2021-08-19 branch August 20, 2021 13:52
@chalin
Copy link
Contributor Author

chalin commented Aug 20, 2021

we likely need to revisit external link checking as a separate issue.

Right. I also mentioned that in #245 (comment), but maybe we need to open a separate issue.

@naiba4 naiba4 mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-double-u nate-double-u nate-double-u approved these changes

Assignees
No one assigned
Labels
infrastructure Categorizes issue or PR as related to site infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalin @nate-double-u