Skip to content

Commit

Permalink
tests: comment explains absence of ETC_Magneto in gen'd difficulty tests
Browse files Browse the repository at this point in the history
Date: 2021-05-06 06:25:57-05:00
Signed-off-by: meows <b5c6@protonmail.com>
  • Loading branch information
meowsbits committed May 6, 2021
1 parent faf705d commit 04b459f
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions tests/difficulty_mgen_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,11 @@ func TestDifficultyTestConfigGen(t *testing.T) {
dt.generateFromReference("Byzantium", "ETC_Atlantis")
dt.generateFromReference("Constantinople", "ETC_Agharta")
dt.generateFromReference("EIP2384", "ETC_Phoenix")
/*
My rationale for not adding ETC_Magneto was that difficulty hasn't changed for the Foundation since EIP2384 Muir Glacier,
and the tests haven't changed in at least that long.
This leads to me to think that adding an ETC_Magneto case would only duplicate the set of ETC_Phoenix.
*/

for k, v := range difficultyChainConfigurations {
dt.config(k, v)
Expand Down Expand Up @@ -167,6 +172,11 @@ func TestDifficultyGen(t *testing.T) {
dt.generateFromReference("Byzantium", "ETC_Atlantis")
dt.generateFromReference("Constantinople", "ETC_Agharta")
dt.generateFromReference("EIP2384", "ETC_Phoenix")
/*
My rationale for not adding ETC_Magneto was that difficulty hasn't changed for the Foundation since EIP2384 Muir Glacier,
and the tests haven't changed in at least that long.
This leads to me to think that adding an ETC_Magneto case would only duplicate the set of ETC_Phoenix.
*/

// Not difficulty-tests
dt.skipLoad("hexencodetest.*")
Expand Down

0 comments on commit 04b459f

Please sign in to comment.