[Tracking] go-ethereum/1.10.2 merge TODOs and tidbits

[meowsbits]

This issue is tracking checklists and TODOs related to the merge of ethereum/go-ethereum 1.10+ series releases and the associated protocol upgrade features. This release series includes features implemented in the Berlin fork, and proposed for Ethereum Classic's tentative Magneto fork.

Overview

PRs are stacked.

• master <- go-ethereum/1.10.1 WIP: merge/foundation release/1.10.2 resolved #348
• WIP: merge/foundation release/1.10.2 resolved #348 <- go-ethereum/1.10.2 Merge/foundation release/1.10.2 resolved #357

TODOs

• tests/testdata. This gets bumped. ethereum/tests has been refilled and now includes something like 150 new tests for Berlin features. I regenerated the tests based on the commit upstream is using.
  • These generated tests need reviewed. Foundation 1.10.1 generated 1617316443 tests#4
    • Read Foundation 1.10.1 generated 1617316443 tests#4 (comment). Review footprint, configuration schemas and presence.
    • This is where the state tests are generated: https://github.com/etclabscore/core-geth/blob/merge/foundation-release/1.10.1-resolved/tests/state_mgen_test.go#L204. Please review.
    • This is where the difficulty tests are generated: https://github.com/etclabscore/core-geth/blob/merge/foundation-release/1.10.1-resolved/tests/difficulty_mgen_test.go#L141. Please review.
• @meowsbits core/blockchain_af_test.go. I resolved conflicts from the hip there. Review.
• @meowsbits Make sure header nil checks/validations are in place. IIRC core-geth has this and go-ethereum does not. I believe must be in place since I believe there is a miner test testing nil header cases.
• [dev@348] panic: invalid number of list elements: 0 #354 panic: invalid number of list elements: 0
• @ziogaschr Review and handle X_Override values (eg. BerlinOverride and --override.berlin, etc.), eg. w/r/t SetupGenesisBlockWithOverride and default config. re Add OverrideMagneto flag #367
• @meowsbits --debug is missing. On purpose? :(
  It becomes log.debug. See a7443c0 for related fixes regarding deprecated pprof flags.
• @meowsbits Add core-geth additional chain flags, re Merge/foundation release/1.10.2 resolved #357 (review).
  Done with 49bd5e7.
• @meowsbits Remove cmd/echaindb, per Merge/foundation release/1.10.2 resolved #357 (review)
  • Proposed with PR build,cmd/echaindb: rm -rf and uses of echaindb command #366
• @ziogaschr Set Magneto activation block numbers for classic|mordor|kotti chains Set activation blocks for Magneto on classic|mordor|kotti chains #368
• @ziogaschr Fixup/review empty version log, noted in WIP: merge/foundation release/1.10.2 resolved #348 (comment) Fix allowing of selecting protocol versions after merge of 1.10.x #373

Testing Checklist

• Developer sync
  • Classic
    • 4e73750 @iquidus
    • 82d0101 @meowsbits
    • d879921 @ziogaschr
  • Mordor
    • 4e73750 @iquidus
    • d879921 @ziogaschr
  • Kotti
    • 4e73750 @iquidus
    • d879921 @ziogaschr
  • Ropsten
  • ETH
• Must pass: Condensed regression tests
• Must pass: Uncondensed regression tests (via Jenkins)
• Extrapolated ethereum/tests suite.
  • Must pass
  • Tests reviewed

[iquidus]

• Classic
  • 4e73750 @iquidus
• Mordor
  • 4e73750 @iquidus

[iquidus]

• Kotti
  • 4e73750 @iquidus

[ziogaschr]

• Mordor
  • d879921 @ziogaschr
• Kotti
  • d879921 @ziogaschr

[meowsbits]

I'm running a --syncmode=snap Classic node at "enode://ce7cbef463c5bac7e310a1ad2279975d8a5b38627f462cd6157a8bd310641ae9e33aae7634afc8b102be864491cba8dd33c9343b94674ba86be8afc74f4721a9@159.203.56.33:30369".

This node should be available indefinitely. I'll restart it when upgrading to the forthcoming next release, but should be stable between and after that.

On ethstats as meowsbits-classic-dev-fun. Developer metrics as host=isaac-rottor-fun.

# ./build/bin/geth version
CoreGeth
Version: 1.11.23-unstable
Git Commit: faf705db58145f9ea61af6caab9041e0237aeefc
Git Commit Date: 20210504
Architecture: amd64
Go Version: go1.15.5
Operating System: linux
GOPATH=/root/go
GOROOT=/root/go1.15.5.linux-amd64

[ziogaschr]

An RC release is being prepared here

[meowsbits]

Great stuff guys, thanks for this. Closing, since v1.12.0-rc1 has been released.