Merge/foundation release/1.10.2 resolved #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* les: add trailing slash to metric namespace * les: omit '.' in metric namespace
Given a list of less than two elements DecodeRLP returned rlp.EOL, leading to issues in outer decoders.
* eth/state, les/state: properly init statedb accesslist when tracing, fixes #22475 * eth: review comments * eth/tracers: fix compilation err * eth/tracers: apply @karalabe's suggested fix
* cmd/geth: remove copydb command * eth/downloader: remove fakepeer
The oss-fuzz fuzzer has been reporting some failing testcases for les. They're all spurious, and cannot reliably be reproduced. However, running them showed that there was a goroutine leak: the tests created a lot of new clients, which started an exec queue that was never torn down. This PR fixes the goroutine leak, and also a log message which was erroneously formatted.
Responding to these comments:
https://github.com/ethereum/go-ethereum/pull/21502/files#r579010962
https://github.com/ethereum/go-ethereum/pull/21502/files#r579021565
https://github.com/ethereum/go-ethereum/pull/21502/files#r579023510
https://github.com/ethereum/go-ethereum/pull/21502/files#r578983734
Flatten the image so we do not have dark text on dark background
* core/rawdb: more verbose error logs + better hashing * core/rawdb: add failing testcase * core/rawdb: properly hash transactions while indexing/unindexing * core/rawdb: exit on error + better log msg
This PR fixes multiple issues with the UDP connection pre-negotiation feature: - the enable condition was wrong (it checked the existence of the DiscV5 struct where it wasn't initialized yet, disabling the feature even if discv5 was enabled) - the server pool queried already connected nodes when the discovery iterators returned them again - servers responded positively before they were synced and really willing to accept connections Metrics are also added on the server side that count the positive and negative replies to served connection queries.
This PR fixes multiple issues with the UDP connection pre-negotiation feature: - the enable condition was wrong (it checked the existence of the DiscV5 struct where it wasn't initialized yet, disabling the feature even if discv5 was enabled) - the server pool queried already connected nodes when the discovery iterators returned them again - servers responded positively before they were synced and really willing to accept connections Metrics are also added on the server side that count the positive and negative replies to served connection queries.
…se (#22508) This PR fixes an issue with the eth66 test suite where, during a readAndServe when the test is manually responding to GetBlockHeader requests, it now responds with a BlockHeaders eth66 packet that includes the inbound request ID.
The wantErr field was disused, and the error returned by HeaderByNumber was not properly tested. This simplifies the error checking using errors.Is and asserts that getting an expected missing header returns ethereum.NotFound. Also adds a nil check condition for header.Number before using big.Int's Sign method.
This adds a new option to avoid sending the transaction which is created by calling a bound contract method.
This pulls in a fix for a corruption issue when the process crashes while a new manifest file is being added.
This pulls in a fix to skip the broadcast on interfaces which are down.
This updates the DNS deployer to use AWS SDK v2. Migration is relatively seamless, although there were two locations that required a slightly different approach to achieve the same results. In particular, waiting for DNS change propagation is very different with SDK v2. This change also optimizes DNS updates by publishing all changes before waiting for propagation.
This fixes the calculation of the tree branch factor. With the new formula, we now creat at most 13 children instead of 30, ensuring the TXT record size will be below 370 bytes.
Date: 2021-04-13 15:55:51-05:00 Signed-off-by: meows <b5c6@protonmail.com>
Date: 2021-04-13 15:56:12-05:00 Signed-off-by: meows <b5c6@protonmail.com>
I haven't figured out where this is getting interpolated to the error value. It seems the error is 'right', but is not being formatted with the details. Date: 2021-04-13 17:02:32-05:00 Signed-off-by: meows <b5c6@protonmail.com>
meowsbits
commented
Apr 13, 2021
meowsbits
commented
Apr 13, 2021
meowsbits
commented
Apr 13, 2021
meowsbits
commented
Apr 13, 2021
meowsbits
commented
Apr 13, 2021
…broken because of the upstream merge
It is needed by the callTracerParity for maintaining 100% OE compatibility
|
I am running a Classic sync now on 82d0101. |
30 tasks
Date: 2021-04-28 06:15:26-05:00 Signed-off-by: meows <b5c6@protonmail.com>
All depcrecated pprof flags were dropped, apparently accidentally. I noticed this because --debug was unavailable. Not only were the flag declarations unregistered, but logical support for pprof.port, addr, and cpuprofile were missing; this adds support for them. Date: 2021-04-28 06:33:15-05:00 Signed-off-by: meows <b5c6@protonmail.com>
Date: 2021-04-28 06:52:00-05:00 Signed-off-by: meows <b5c6@protonmail.com>
This small program's functionality has been replace with the new 'geth db' command. Date: 2021-04-28 07:00:28-05:00 Signed-off-by: meows <b5c6@protonmail.com>
…0.2-resolved-rmrf-cmd-echaindb build,cmd/echaindb: rm -rf and uses of echaindb command
ziogaschr
approved these changes
May 4, 2021
…undation-release/1.10.2-resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #348.
See related Tracking Issue for TODOs and review status.