Support trace API similar to OpenEthereum/Parity's one #211

ziogaschr · 2020-10-15T09:18:06Z

This PR adds a compatible trace API with OpenEthereum's one.

At the moment we have implemented:

trace_transaction
trace_block

For a node to enable this feature, it has to start with --vmdebug flag.

For the best performance node has to be synced in archive mode.
In console the trace API can be used.
Last, the trace RPC API is available, though it have to be enabled.

Fixes #100.

Work in Progress. Opened a PR to handle discussion over here.

…o OpenEthereum # Conflicts: # eth/tracers/internal/tracers/assets.go

…hereum

…on` in response

@tjayrush

… RPC Based on @tjayrush commit erigontech/erigon@47f59e8

js/tracers: make calltracer report value in selfdestructs (#21549) ethereum/go-ethereum@71c37d8

.

…curate)

…st references

ziogaschr · 2020-11-03T09:31:33Z

At this point we reached 100% compatibility with OpenEthereum tracers for trace_block and trace_transaction at Mordor testnet chain.

meowsbits · 2020-11-03T13:05:36Z

State tests are failing, looks like it could be an issue with CREATE gas. Possibly related to c32bcd6.

To re/produce: go test ./tests/

They look mostly like out of gas cases, maybe?

…e on EIP150

consensus/ethash/consensus.go

meowsbits · 2020-11-05T11:26:23Z

core/vm/logger.go

@@ -106,7 +106,7 @@ func (s *StructLog) ErrorString() string {
 // if you need to retain them beyond the current call.
 type Tracer interface {
 	CaptureStart(from common.Address, to common.Address, create bool, input []byte, gas uint64, value *big.Int) error
-	CaptureState(env *EVM, pc uint64, op OpCode, gas, cost uint64, memory *Memory, stack *Stack, rStack *ReturnStack, rData []byte, contract *Contract, depth int, err error) error
+	CaptureState(env *EVM, pc uint64, op OpCode, gas, availableGas, cost uint64, memory *Memory, stack *Stack, rStack *ReturnStack, rData []byte, contract *Contract, depth int, err error) error


@ziogaschr I think you mentioned yesterday that this parameter may be removable since this value is equivalent to env.callGasTemp. If so, is it worth doing?

At this point removed the extra availableGasCopy and use the in.evm.callGasTemp. This one can be removed if I make it public as in.evm.CallGasTemp. What do you think about it?

I think it's OK to make it public because that follows the pattern that we've already "allowed" with the introduction of EVM.CallErrorTemp, and IMO publicizing a field there is less "expensive" than adding a parameter to a shared interface.

consensus/ethash/consensus.go

@iquidus

based on @iquidus suggestion

consensus/ethash/consensus.go

This is an unnecessary condition since each uncle will always get one reward (and they're in a known and constant order), so len(uncleRewards) will always be len(uncles). Signed-off-by: meows <b5c6@protonmail.com>

meowsbits

❌ go test ./eth/tracers/... is failing

Eg. https://travis-ci.org/github/etclabscore/core-geth/jobs/741433701#L960

…w.json`

@meowsbits

Nice catch @meowsbits. I fixed the existing foundation call_tracer which I broke with the changes with regards gas. p.s.: Haven't checked the Travis failures as I noted them as broken most of the times a while back. Have we fixed them?

meowsbits · 2020-11-05T20:55:24Z

I'm going to merge this, but just noting the following CI suites failed at the same test, which is unusual. I could, however, not
reproduce this locally so I'm assuming this as unrelated issue, though one that we may need to follow up with.

This is a core-geth -specific integration test.

--- FAIL: TestGenerateBlockAndImport_CG1 (0.00s)

    --- FAIL: TestGenerateBlockAndImport_CG1/all-ethash (3.01s)

        worker_cg_test.go:77: timeout: 1

FAIL

ziogaschr added 30 commits October 6, 2020 00:16

tracer: Add call_tracer_open_ethereum with formatted output similar t…

6be3792

…o OpenEthereum # Conflicts: # eth/tracers/internal/tracers/assets.go

tracer: Expose trace_traceTransaction API (draft, might change)

0bcd35b

tracer: Add trace_traceBlock* methods

5752398

Rename TraceBlockByNumber to TraceBlock for compatibility with OpenEt…

c2b0717

…hereum

Rename trace methods for compatibility with OpenEthereum names

7a4afdb

tracer: add dump trace_filter func

9228a99

tracer: include blockHash, transactionHash and `transactionPositi…

8efa8a4

…on` in response

tracer: small change to accumulateRewards to make it available to the…

7770fc1

… RPC Based on @tjayrush commit erigontech/erigon@47f59e8

tracer: restructure PrivateTraceAPI to its own file

590fdf2

tracer: add block/uncle rewards in trace_block

66362d8

tracer: reorder tracer json fields

7b56e95

Cleanup

350afc9

tracer: handle gas 2300 stipend

548de0d

tracer: Add mapping of core-geth errors to OpenEthereum ones

da1a1ec

tracer: handle op=selfdestruct similar to OpenEthereum

b5b4990

tracer: cleanup reward structs

f6996ac

tracer: JS better handling of typeof undefined

2ec697c

tracer: JS rename oeErrorMapping

9ac36bd

tracer: JS cleanup 🧽

f583aaa

tracer: JS refactor/cleanup finalize()

3c07e02

tracer: JS add additional error maps

8a2dd93

js/tracers: make OpenEthereum calltracer report value in selfdestructs

5ddf481

js/tracers: make calltracer report value in selfdestructs (#21549) ethereum/go-ethereum@71c37d8

tracer: JS better handling of gas and gasUsed (remove the stipend hack)

860f014

tracer: JS OE compatibility fixes

82c221d

tracer: JS handle out of gas errors

8c5a412

tracer: JS temp hack for compatibility (to be changed)

05bfa16

tracer: fix handling of op=delegatecall value

791c601

.

tracer: better naming for isDynamicGas variable (still not sure if ac…

4e4f55b

…curate)

tracer: add more error mappings

e3fcba6

tracer: op=CREATE2 to return type=CREATE for OE compatibility

fa1a6b6

ziogaschr added 3 commits November 3, 2020 01:26

tracers: generate assets.go

0de90ff

tracers/js: cleanup

e4a3a5c

tracer: Rename call_tracer_open_ethereum to call_tracer_parity and re…

88bbfb2

…st references

tracer: fix lint issues

c89f77c

ziogaschr added 6 commits November 4, 2020 12:45

tracer/js: add TODO comment

39fcedf

core/vm: track 63/64 create gas off stack (fix)

dbe01d4

tracers: generate assets.go

05f0d9c

core/vm: add createGasEip150 for CREATE/CREATE2 gas calc of 63/64 rul…

c5b5386

…e on EIP150

core/vm: cleanup use of evm.callGasTemp in interpreter

b66cd1c

Merge branch 'master' into feat/openethereum-trace-apis

0f710a4

ziogaschr commented Nov 4, 2020

View reviewed changes

consensus/ethash/consensus.go Outdated Show resolved Hide resolved

ziogaschr changed the title ~~[WiP] Support trace API similar to OpenEthereum's one~~ Support trace API similar to OpenEthereum/Parity's one Nov 4, 2020

meowsbits reviewed Nov 5, 2020

View reviewed changes

iquidus reviewed Nov 5, 2020

View reviewed changes

consensus/ethash/consensus.go Outdated Show resolved Hide resolved

consensus/ethash/consensus.go Outdated Show resolved Hide resolved

consensus/ethash: better name for AccumulateRewards -> GetRewards

ad4fdbe

based on @iquidus suggestion

meowsbits reviewed Nov 5, 2020

View reviewed changes

consensus/ethash/consensus.go Outdated Show resolved Hide resolved

ethash: remove unnecessarily defensive conditional

e1a3c01

This is an unnecessary condition since each uncle will always get one reward (and they're in a known and constant order), so len(uncleRewards) will always be len(uncles). Signed-off-by: meows <b5c6@protonmail.com>

meowsbits previously requested changes Nov 5, 2020

View reviewed changes

ziogaschr added 2 commits November 5, 2020 16:42

core/vm, eth/tracers: make evm.callGasTemp public evm.CallGasTemp

45d5f66

eth/tracers: fix broken test `call_tracer_inner_create_oog_outer_thro…

e447981

…w.json`

ziogaschr requested a review from meowsbits November 5, 2020 15:40

meowsbits approved these changes Nov 5, 2020

View reviewed changes

meowsbits merged commit e447981 into master Nov 5, 2020

meowsbits deleted the feat/openethereum-trace-apis branch November 5, 2020 20:56

ziogaschr restored the feat/openethereum-trace-apis branch November 10, 2020 14:29

ziogaschr deleted the feat/openethereum-trace-apis branch November 10, 2020 14:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support trace API similar to OpenEthereum/Parity's one #211

Support trace API similar to OpenEthereum/Parity's one #211

ziogaschr commented Oct 15, 2020 •

edited

Loading

ziogaschr commented Nov 3, 2020

meowsbits commented Nov 3, 2020 •

edited

Loading

meowsbits Nov 5, 2020

ziogaschr Nov 5, 2020

meowsbits Nov 5, 2020

meowsbits left a comment •

edited

Loading

meowsbits commented Nov 5, 2020

Support trace API similar to OpenEthereum/Parity's one #211

Support trace API similar to OpenEthereum/Parity's one #211

Conversation

ziogaschr commented Oct 15, 2020 • edited Loading

ziogaschr commented Nov 3, 2020

meowsbits commented Nov 3, 2020 • edited Loading

meowsbits Nov 5, 2020

Choose a reason for hiding this comment

ziogaschr Nov 5, 2020

Choose a reason for hiding this comment

meowsbits Nov 5, 2020

Choose a reason for hiding this comment

meowsbits left a comment • edited Loading

Choose a reason for hiding this comment

meowsbits commented Nov 5, 2020

ziogaschr commented Oct 15, 2020 •

edited

Loading

meowsbits commented Nov 3, 2020 •

edited

Loading

meowsbits left a comment •

edited

Loading