cmd/faucet/main: adds flag use audit checks and refactors logic #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-ethstats and -bootnodes and -network flags were not being checked for exclusivity with -attach. Adding those checks, this also refactors the auditor function. Date: 2021-01-05 07:02:15-06:00 Signed-off-by: meows <b5c6@protonmail.com>
meowsbits
changed the title
meowsbits
commented
Jan 8, 2021
cmd/faucet/faucet.go
Outdated
| {{"attach", attachFlag}, {"chain.<identity>", activeChainFlag}}, | ||
| {{"attach", attachFlag}, {"genesis", genesisFlag}}, | ||
| {{"attach", attachFlag}, {"ethstats", statsFlag}}, | ||
| {{"attach", attachFlag}, {"ethport", ethPortFlag}}, |
There was a problem hiding this comment.
ethPortFlag defaults to a nonzero 30303. Thanks @ziogaschr for catching this.
The ethPort default value is nonzero, making this check incorrect. Resolves #276 (comment) Date: 2021-01-08 06:18:43-06:00 Signed-off-by: meows <b5c6@protonmail.com>
ziogaschr
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-ethstats and -bootnodes and -network flags
were not being checked for exclusivity with -attach.
Adding those checks, this also refactors the auditor
function.
Date: 2021-01-05 07:02:15-06:00
Signed-off-by: meows b5c6@protonmail.com