-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build,Makefile: add 'make mkdocs-serve' #294
Conversation
This adds a script and associated Makefile command to handle installing requirements and starting the development server for mkdocs. Signed-off-by: meows <b5c6@protonmail.com>
I wonder if we should add the creation of a virtualenv within the script. As it currently installs the packages globally in the system. Though not all the developers know/like how to use virtualenvs and at the end a |
Maybe we should just use Then we get to have no opinions about Python or environments... |
No strong preference on this one. I liked the idea of your script as core-geth is a go project and their users might not know much about python, while most systems have python installed. |
I'm OK leaving out EDIT: @ziogaschr Just saw your commit 946fa86 -- LGTM. |
Would it make sense adding this in both README and docs? Something across the lines of using MkDocs and here is how to install it and run it locally. |
It was getting assigned only before the python command was finally assigned. Signed-off-by: meows <b5c6@protonmail.com>
bc08bdf
to
aaed10b
Compare
Date: 2021-01-13 06:42:04-06:00 Signed-off-by: meows <b5c6@protonmail.com>
aaed10b
to
54d5589
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: meows <b5c6@protonmail.com>
This adds a script and associated Makefile command
to handle installing requirements and starting the
development server for mkdocs.
Signed-off-by: meows b5c6@protonmail.com