Feat/ecip1100 force enable #303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully this makes the fields value a little clearer (as a status/state rather than setting). Date: 2021-01-14 12:05:02-06:00 Signed-off-by: meows <b5c6@protonmail.com>
…n override This provides a CLI flag --ecbp1100.nodisable which forces the ECBP1100 logic to an always state, prevent the auto-shutoff mechanisms (trigger on below-threshold peer count and stale head for a time beyond a certain time window) from disabling the ECBP1100 artificial finality logic. Date: 2021-01-14 12:07:26-06:00 Signed-off-by: meows <b5c6@protonmail.com>
Date: 2021-01-14 12:24:55-06:00 Signed-off-by: meows <b5c6@protonmail.com>
Comments are added noting that - the protocol manager 'safety loop' is short-circuited if the state is force-set, only for the reason of saving a noop goroutine. Note that if the override becomes configurable at runtime, this would need to be cut. - min peers check is allowed to still call the EnableArtificialFunction(true/false) since it will be a noop either way if the override is in place. Date: 2021-01-14 12:40:15-06:00 Signed-off-by: meows <b5c6@protonmail.com>
Date: 2021-01-14 12:53:21-06:00 Signed-off-by: meows <b5c6@protonmail.com>
Date: 2021-01-14 12:59:43-06:00 Signed-off-by: meows <b5c6@protonmail.com>
Date: 2021-01-14 12:59:55-06:00 Signed-off-by: meows <b5c6@protonmail.com>
The cost of one noop goroutine vs. potential unexpected logic is not worth it. Would rather call the noop and keep the AF enable/disable logic in one place. Date: 2021-01-14 13:06:12-06:00 Signed-off-by: meows <b5c6@protonmail.com>
Now use becomes --ecbp1100.force where that enables forceful activation. Date: 2021-01-15 05:19:35-06:00 Signed-off-by: meows <b5c6@protonmail.com>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #299. Where 299 exposes ECBP1100's auto-shutoff limits to the user as configuration options, this approach instead exposes a configuration option
--ecbp1100.force=[on|off].This is
1 == onand0 == off.Existing toggle methods are allowed to maintain their call logic, but their handler
func (bc *BlockChain) EnableArtificialFinality(enable bool, logValues ...interface{})short-circuits if the force state is active.