Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth: update default extraData #310

Merged
merged 2 commits into from
Feb 3, 2021
Merged

eth: update default extraData #310

merged 2 commits into from
Feb 3, 2021

Conversation

iquidus
Copy link
Contributor

@iquidus iquidus commented Jan 21, 2021

updates the default extraData field, from geth -> CoreGeth to be consistent with both geth version and ethstats.

@meowsbits meowsbits self-requested a review January 21, 2021 19:24
meowsbits
meowsbits reviewed Jan 21, 2021
View reviewed changes
Copy link
Contributor

@meowsbits meowsbits left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have a test for this... just to prove at least that the encoding works as expected, say, for the new capitalized characters...

EDIT Added ✅

@meowsbits
eth: add basic test for extradata default client identifier
c9b3473 
Date: 2021-01-22 05:51:22-06:00
Signed-off-by: meows <b5c6@protonmail.com>
@meowsbits meowsbits merged commit e24799e into master Feb 3, 2021
@meowsbits meowsbits deleted the fix/extraData branch February 3, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meowsbits meowsbits meowsbits approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iquidus @meowsbits