Refactor/merge stateDiff from master on upstream release/1.10.1 #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eth: add test for stateDiff tracer
eth, eth/tracers: resolve state_diff misconsistencies eth: pass extra context to call JS tracers hasFromSufficientBalance*
eth: traceCall to use original TransferFunc instead of copy the logic and take care of mutating the value
…CapturePreEVM Till this point, state_diff was manually calculating balance/nonce changes that have been executed pre/post EVM execution. This was error prone, as any change in consensus within go, will have to be transfered to JS logic as well. This commit tackles this issue, by adding an init() method call, before anything is be run for a transaction. eth: clean up vmctx.Tracer (pointer, refs, oh my) Date: 2021-03-12 15:09:48-06:00 Signed-off-by: meows <b5c6@protonmail.com>
… code after the upstream merge
eth/tracers: remove commented out forgoten code eth/tracers: remove unused types from tests eth: fix lint issue :( eth: remove spurious comment
Rel #345 (comment) @ziogaschr, revert this if you hate it ;) Date: 2021-03-30 16:55:21-05:00 Signed-off-by: meows <b5c6@protonmail.com>
It reassigns the `err` var in the if context instead of changing the outer context for the function return
I removed by mistake the stateDiff parts on previous commit, as I thought I was working on the PR #348.
Co-authored-by: meowsbits <b5c6@protonmail.com>
Implement stateDiff tracer, compatible with OpenEthereum
# Conflicts: # core/state_transition.go # core/vm/logger.go # eth/tracers/api.go # eth/tracers/api_parity.go # eth/tracers/internal/tracers/assets.go # eth/tracers/internal/tracers/prestate_tracer.js # eth/tracers/tracer.go
ziogaschr
deleted the
merge/foundation-release/1.10.1-resolved-stateDiff
branch
|
🐿 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.