add --classic: ETC treads lightly (v. master, retesteth) #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* graphql: fix tx logs * minor * Use optimized search for selecting tx logs
* graphql: fix tx logs * graphql: refactor test service setup * graphql: add test for tx logs
Date: 2022-10-27 09:16:05-07:00 Signed-off-by: meows <b5c6@protonmail.com>
…p155 impls; ETC forkid impl Date: 2022-10-27 09:46:38-07:00 Signed-off-by: meows <b5c6@protonmail.com>
…hash pkg Date: 2022-10-27 11:09:17-07:00 Signed-off-by: meows <b5c6@protonmail.com>
…classic flag/config and associated ethash inits Date: 2022-10-27 11:36:34-07:00 Signed-off-by: meows <b5c6@protonmail.com>
Date: 2022-10-27 11:37:02-07:00 Signed-off-by: meows <b5c6@protonmail.com>
…sis hashes Date: 2022-10-27 11:46:48-07:00 Signed-off-by: meows <b5c6@protonmail.com>
…/tests-etc) Date: 2022-10-27 13:00:03-07:00 Signed-off-by: meows <b5c6@protonmail.com>
Date: 2022-10-27 13:13:45-07:00 Signed-off-by: meows <b5c6@protonmail.com>
Date: 2022-10-27 13:17:15-07:00 Signed-off-by: meows <b5c6@protonmail.com>
Date: 2022-10-27 13:39:53-07:00 Signed-off-by: meows <b5c6@protonmail.com>
A few tests remain failing; apparently all for chain id reasons; do the tests have proper chain id values? They should be 61 for ETC. Date: 2022-10-27 15:57:50-07:00 Signed-off-by: meows <b5c6@protonmail.com>
Date: 2022-10-27 16:07:14-07:00 Signed-off-by: meows <b5c6@protonmail.com>
Date: 2022-10-28 09:23:37-07:00 Signed-off-by: meows <b5c6@protonmail.com>
Date: 2022-11-01 10:29:42-07:00 Signed-off-by: meows <b5c6@protonmail.com>
Date: 2022-11-01 10:31:31-07:00 Signed-off-by: meows <b5c6@protonmail.com>
…1.12) When running the 'evm' command via retesteth, a panic occurs and the trace has this dep at the top of the pile. This is a blind attempt to resolve the issue by upgrading dependencies. Date: 2022-11-01 10:38:40-07:00 Signed-off-by: meows <b5c6@protonmail.com>
Running retesteth with --t8ntool --filltests --j8
(or any --jX > 1) caused the suite to panic.
Geth/evm was panicing about here.
This fixes it.
It (the panic) looked like this...
goroutine 8 [chan receive]:
github.com/ethereum/go-ethereum/core.(*txSenderCacher).cache(0x0?)
github.com/ethereum/go-ethereum/core/sender_cacher.go:63 +0x3b
created by github.com/ethereum/go-ethereum/core.newTxSenderCacher
github.com/ethereum/go-ethereum/core/sender_cacher.go:55 +0x75
goroutine 9 [chan receive]:
github.com/ethereum/go-ethereum/core.(*txSenderCacher).cache(0x0?)
github.com/ethereum/go-ethereum/core/sender_cacher.go:63 +0x3b
created by github.com/ethereum/go-ethereum/core.newTxSenderCacher
github.com/ethereum/go-ethereum/core/sender_cacher.go:55 +0x75
goroutine 10 [chan receive]:
github.com/ethereum/go-ethereum/core.(*txSenderCacher).cache(0x0?)
github.com/ethereum/go-ethereum/core/sender_cacher.go:63 +0x3b
created by github.com/ethereum/go-ethereum/core.newTxSenderCacher
github.com/ethereum/go-ethereum/core/sender_cacher.go:55 +0x75
goroutine 11 [chan receive]:
github.com/ethereum/go-ethereum/core.(*txSenderCacher).cache(0x0?)
github.com/ethereum/go-ethereum/core/sender_cacher.go:63 +0x3b
created by github.com/ethereum/go-ethereum/core.newTxSenderCacher
github.com/ethereum/go-ethereum/core/sender_cacher.go:55 +0x75
Date: 2022-11-01 08:16:04-07:00
Signed-off-by: meows <b5c6@protonmail.com>
Conflicts:
cmd/utils/flags.go
core/genesis.go
eth/backend.go
eth/ethconfig/config.go
go.sum
params/config.go
params/version.go
Date: 2022-11-01 10:54:44-07:00 Signed-off-by: meows <b5c6@protonmail.com>
ziogaschr
reviewed
Nov 1, 2022
| @@ -335,7 +335,7 @@ func (st *StateTransition) TransitionDb() (*ExecutionResult, error) { | |||
| ret, st.gas, vmerr = st.evm.Call(sender, st.to(), st.data, st.gas, st.value) | |||
| } | |||
|
|
|||
| if !rules.IsLondon { | |||
| if !rules.IsLondon && !rules.IsMystique { | |||
There was a problem hiding this comment.
@meowsbits, do you think that IsETCMystique is a better name, so as devs can see that it's similar forks and not two different forks on the same chain?
There was a problem hiding this comment.
This idea applies to all our forks
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #12, which intends to create a "slim" patch that implements ETC support for the upstream ethereum/go-ethereum programs.
While that PR is based on a latest tag branch (
release/1.10), this PR is based on themasterbranch (which, incidentally, indicates that ethereum/go-ethereum is moving to v1.11).masterwas merged with the original feature branch (etc-treads-lightly).baseFeeissue thatretestethexposedThe
-retestssuffix indicates that this branch is intended to work in development with retesteth toward filling and running tests. To that aim, a couple more commits are included, addressing further issues encountered during interoperation withretesteth; namely panics coming from go-ethereum'sevm t8ntool when run in parallel (eg.-j8) with retesteth.