Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update morden bootnodes #16

Merged
merged 2 commits into from
Jul 30, 2019
Merged

Update morden bootnodes #16

merged 2 commits into from
Jul 30, 2019

Conversation

austinabell
Copy link
Contributor

Updates from dead bootnodes to most updated list

@austinabell austinabell requested a review from noot as a code owner July 29, 2019 20:05
@steviezhang steviezhang self-requested a review July 29, 2019 21:00
@soc1c
Copy link
Contributor

soc1c commented Jul 29, 2019

that won't fix the networking issues on startup discussed earlier today, does it? @tzdybal

@tzdybal
Copy link
Contributor

tzdybal commented Jul 29, 2019

@soc1c it resolves the symptoms of the issue (I'm able to start syncing!), but not the cause of the problem with Discovery.

@GregTheGreek GregTheGreek merged commit c248a8a into development Jul 30, 2019
@soc1c soc1c deleted the bootnodesupdate branch July 31, 2019 19:01
@soc1c soc1c mentioned this pull request Aug 2, 2019
3 tasks
soc1c pushed a commit that referenced this pull request Aug 2, 2019
* Updates bootnodes

* what a fantastic test :)
@soc1c
Copy link
Contributor

soc1c commented Aug 2, 2019

it resolves the symptoms of the issue (I'm able to start syncing!)

the issue still persists after this patch

@austinabell
Copy link
Contributor Author

it resolves the symptoms of the issue (I'm able to start syncing!)

the issue still persists after this patch

It was never intended to fix gethc networking, just to update the list of bootnodes to make it slightly quicker to sync to Morden for now so people don't have to manually update the bootnodes. I haven't had an actual problem syncing up, although it definitely is slow.

soc1c added a commit that referenced this pull request Aug 7, 2019
* Fixed state transition logic for edge case (#17)

* Update morden bootnodes (#16)

* Updates bootnodes

* what a fantastic test :)

* Core execution refactor, EIP 684, edge case fixes, starting nonce for morden (#19)

* Refactored Call

* Refactored CallCode

* Refactored DelegateCall

* Refactored StaticCall

* Added create before contract collision check

* Refactored Call

* Refactored CallCode

* Refactored DelegateCall

* Refactored StaticCall

* Added create before contract collision check

* Fixed state transition logic for edge case

* Added create collision logic

* Fix for edge case tests

* Removed outdated contract collision tests and changed format of test output to be consistent

* Rename exec function

* utilize StartingNonce from state instead of explicit 0 nonce checks for contract collision and empty objects

* Fixes morden seg fault edge case

* adding starting nonce to created contracts
@soc1c soc1c added this to the 6.0 Atlantis milestone Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants