Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(doc): add initial readme for jade-service-runner #3

Merged
merged 4 commits into from
Apr 30, 2019

Conversation

zcstarr
Copy link
Contributor

@zcstarr zcstarr commented Apr 25, 2019

Its a definite WIP atm, just figured I'd file this as well as the issue #2 .

@zcstarr zcstarr requested a review from BelfordZ April 25, 2019 00:19
README.md Outdated Show resolved Hide resolved
Co-Authored-By: zcstarr <zcstarr@gmail.com>
Copy link
Contributor

@BelfordZ BelfordZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation isn't what I think you meant to do

README.md Outdated
Running and accessing JSON-RPC services is currently difficult. JSON-RPC services are a defacto standard for communicating with decentralized services. Developers need to perform one or more of the following tasks
to ensure their dApps has access to the services it needs to run.
- embed the service directly in the App
- approach can potentially suffer from bloat, if the service takes alot of resources to run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- approach can potentially suffer from bloat, if the service takes alot of resources to run
- approach can potentially suffer from bloat, if the service takes alot of resources to run

README.md Outdated
- embed the service directly in the App
- approach can potentially suffer from bloat, if the service takes alot of resources to run
- use a remote centralized node (CryptoKitties)
- this route leads to some centralization in, the sense that traffic has to flow through a centralized point
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- this route leads to some centralization in, the sense that traffic has to flow through a centralized point
- this route leads to some centralization in, the sense that traffic has to flow through a centralized point

README.md Outdated
- use a remote centralized node (CryptoKitties)
- this route leads to some centralization in, the sense that traffic has to flow through a centralized point
- rely on the user to have the service configured and running ambiently
- this approach is the most difficult for, the end user, as it requires setup from the end user's perspective
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- this approach is the most difficult for, the end user, as it requires setup from the end user's perspective
- this approach is the most difficult for, the end user, as it requires setup from the end user's perspective

README.md Outdated Show resolved Hide resolved
Co-Authored-By: zcstarr <zcstarr@gmail.com>
@zcstarr zcstarr self-assigned this Apr 29, 2019
@zcstarr zcstarr merged commit 493b867 into master Apr 30, 2019
@zcstarr
Copy link
Contributor Author

zcstarr commented Jun 1, 2019

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants