Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zune-jpeg: noisy log spam #131

Closed
emilk opened this issue Jun 9, 2023 · 4 comments
Closed

zune-jpeg: noisy log spam #131

emilk opened this issue Jun 9, 2023 · 4 comments

Comments

@emilk
Copy link

emilk commented Jun 9, 2023

zune-jpeg uses very verbose log levels:

[2023-06-09T14:27:50Z INFO  zune_jpeg::decoder] Image encoding scheme =`Baseline DCT`
[2023-06-09T14:27:50Z INFO  zune_jpeg::headers] Image width  :1440
[2023-06-09T14:27:50Z INFO  zune_jpeg::headers] Image height :1920
[2023-06-09T14:27:50Z INFO  zune_jpeg::headers] Image components : 3
[2023-06-09T14:27:50Z INFO  zune_jpeg::components] Component ID:Y       HS:2 VS:2 QT:0
[2023-06-09T14:27:50Z INFO  zune_jpeg::components] Component ID:Cb      HS:1 VS:1 QT:1
[2023-06-09T14:27:50Z INFO  zune_jpeg::components] Component ID:Cr      HS:1 VS:1 QT:1
[2023-06-09T14:27:50Z INFO  zune_jpeg::decoder] Input colorspace YCbCr
[2023-06-09T14:27:50Z WARN  zune_jpeg::decoder] Headers decoded!
[2023-06-09T14:27:50Z INFO  zune_jpeg::decoder] Vertical and horizontal sub-sampling(2,2)
[2023-06-09T14:27:50Z INFO  zune_jpeg::mcu] Found EOI marker
[2023-06-09T14:27:50Z INFO  zune_jpeg::mcu] Finished decoding image

This means any user of the library will have to manually mute the logs from zune-jpeg if they want any sort of log hygiene.

I suggest lowering all these to TRACE, or DEBUG at most. Users can always opt-in to more verbose logging with RUST_LOG=zune-jpeg=trace if they want it (e.g. when debugging zune-jpeg).

@etemesi254
Copy link
Owner

will do in a few

@etemesi254
Copy link
Owner

Moved them to trace in 6bf3480

Will move other libraries to trace as time goes by

@emilk
Copy link
Author

emilk commented Aug 14, 2023

Thanks for fixing this in zune-jpeg, but now it is zune_png that is annoying me :)

@etemesi254
Copy link
Owner

cleaning them one by one

about to make a big release in a few days with most logs changed to trace (and some new formats) will address this beforehand

etemesi254 added a commit that referenced this issue Aug 15, 2023
Replace `info!` with `trace!` for all decoders to reduce log verbosity for the library that may depend on the decoder.

Addresses #131 (comment)

Signed-off-by: caleb <etemesicaleb@gmail.com>
etemesi254 added a commit that referenced this issue Oct 21, 2023
Replace `info!` with `trace!` for all decoders to reduce log verbosity for the library that may depend on the decoder.

Addresses #131 (comment)

Signed-off-by: caleb <etemesicaleb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants