fixing some warnings

added some words to the dictionary
making the about dialog have the logo scaled correctly

cspell.config.yaml

@@ -19,11 +19,13 @@ words:
   - Fabien
   - hexview
   - Kabatsayev
+  - konsole
   - Mercês
   - METATYPE
   - Mohd
   - nasm
   - Nicoleau
+  - nofork
   - Noto
   - Olly
   - Ollydbg
@@ -44,6 +46,7 @@ words:
   - Scrollbars
   - Shahril
   - Sorokin
+  - stepover
   - tbyte
   - Teran
   - xmmword

include/Register.h

@@ -81,7 +81,7 @@ class EDB_EXPORT Register {
 			result = -1ll;
 			std::memcpy(&result, &value_, bitSize_ / 8);
 		}
-		return result;
+		return static_cast<int64_t>(result);
 	}
 
 	void setScalarValue(std::uint64_t newValue);

plugins/DebuggerCore/DebuggerCoreBase.cpp

@@ -102,7 +102,7 @@ std::shared_ptr<IBreakpoint> DebuggerCoreBase::findTriggeredBreakpoint(edb::addr
 
 /**
  * Decrements the reference count for the breakpoint found at the given address.
- * If the refernce count goes to zero, then it is removed.
+ * If the reference count goes to zero, then it is removed.
  * This is a no-op if there is no breakpoint present.
  *
  * @brief DebuggerCoreBase::removeBreakpoint

plugins/DebuggerCore/unix/Unix.cpp

@@ -200,18 +200,18 @@ Status Unix::execute_process(const QString &path, const QString &cwd, const QLis
 		// instead appear to launch shell
 		const int ret = execv(argv_pointers[0], argv_pointers);
 
-		// should be no need to cleanup, the process which allocated all that
-		// space no longer exists!
 		// if we get here...execv failed!
-		if (ret == -1) {
-			errorString = QString("execv() failed: %1").arg(strerror(errno));
-
-			p = argv_pointers;
-			while (*p) {
-				delete[] *p++;
-			}
-			delete[] argv_pointers;
+		// and the docs say that the return value IS -1. This behavior of execv only
+		// returning on errors confuses linters, so let's just assert what is the case
+		Q_ASSERT(ret == -1);
+
+		errorString = QString("execv() failed: %1").arg(strerror(errno));
+
+		p = argv_pointers;
+		while (*p) {
+			delete[] *p++;
 		}
+		delete[] argv_pointers;
 	}
 
 	// frankly, any return is technically an error I think

plugins/InstructionInspector/Plugin.cpp

@@ -793,8 +793,7 @@ std::string runOBJDUMP(const std::vector<std::uint8_t> &bytes, edb::address_t ad
 			"--insn-width=15",
 			"--architecture=i386" + QString(bits == 64 ? ":x86-64" : ""),
 			"-M",
-			"intel,"
-			"intel-mnemonic",
+			"intel,intel-mnemonic",
 #elif defined(EDB_ARM32)
 								   "--insn-width=4",
 								   "-m",

src/DialogAbout.ui

@@ -18,11 +18,29 @@
     <layout class="QHBoxLayout" name="horizontalLayout">
      <item>
       <widget class="QLabel" name="label">
-       <property name="text">
-        <string/>
+       <property name="sizePolicy">
+        <sizepolicy hsizetype="Fixed" vsizetype="Fixed">
+         <horstretch>0</horstretch>
+         <verstretch>0</verstretch>
+        </sizepolicy>
+       </property>
+       <property name="minimumSize">
+        <size>
+         <width>100</width>
+         <height>100</height>
+        </size>
+       </property>
+       <property name="maximumSize">
+        <size>
+         <width>100</width>
+         <height>100</height>
+        </size>
        </property>
        <property name="pixmap">
-        <pixmap resource="debugger.qrc">:/debugger/images/edb.svg</pixmap>
+        <pixmap resource="res/debugger.qrc">:/debugger/images/edb.svg</pixmap>
+       </property>
+       <property name="scaledContents">
+        <bool>true</bool>
        </property>
       </widget>
      </item>

src/capstone-edb/include/Instruction.h

@@ -71,7 +71,7 @@ class EDB_EXPORT Instruction {
 	}
 
 public:
-	int operation() const { return insn_ ? insn_->id : 0; }
+	unsigned int operation() const { return insn_ ? insn_->id : 0; }
 	std::size_t operandCount() const {
 #if defined(EDB_X86) || defined(EDB_X86_64)
 		return insn_ ? insn_->detail->x86.op_count : 0;