Fix solutions being reloaded when switching to feedback mode #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, when switching to feedback mode we re-queried solutions, even if we already passed them from the design browser.
Also, even if it was required, it was being loaded twice. This changes the behavior to use the previously-fetched
solutions if available without refetching, and if a fetch is needed, only fetching once. This is particularly valuable for
puzzles with large amounts of solutions where it is time and memory intensive to load all solutions.
Testing
Loaded feedback view for OKR2 via design browser and directly