Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont allow p(unpaired) to be less than 0 #843

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Conversation

luxaritas
Copy link
Member

Conventionally, dot plots are probability matrices such that for any base, the probability that it will pair with any other base will sum to 1, less the probability that it is unpaired - with probability unpaired excluded, so to get the probability unpaired we sum and subtract from 1. However for an algorithm like ribonanzanet, the dot plot is instead a likelihood matrix such that the liklihood of each pair is independent of every other pair, meaning it could sum to more than 1. We now clip P(unp) to so that if the row sums to a value > 1, we don't drop p(unp) to be below 0, which doesn't make sense (it is still ambiguous what p(unp) should be if you have two pairs at .75 liklihood, but this is at least better).

This reflects a change made in DasLab/arnie#50

@luxaritas luxaritas merged commit 104b254 into dev Feb 28, 2025
1 check passed
@luxaritas luxaritas deleted the fix/unnormalized-p-unp branch February 28, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant