Skip to content

Commit

Permalink
remove completed todo comment
Browse files Browse the repository at this point in the history
  • Loading branch information
@devanoneth
devanoneth committed Apr 24, 2024
1 parent 6df375d commit c47140c
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/services/tx/extractTxInfo.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,6 @@ export const extractTxDetails = async (
const dataByteLength = safeTx.data.data ? Buffer.byteLength(safeTx.data.data) : 0
const dataSize = dataByteLength >= 2 ? Math.floor((dataByteLength - 2) / 2) : 0

// TODO(devanon): extract more data similar to
// https://github.com/safe-global/safe-client-gateway/blob/5293d98286bee62f1a7d13c3a405ed8e73bcf770/src/routes/transactions/mappers/common/transaction-info.mapper.ts#L64
const txInfo: Custom = {
type: TransactionInfoType.CUSTOM,
to: addressEx(safeTx.data.to),
Expand Down

1 comment on commit c47140c

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage report

Caution

Test run failed

St.❔
 Category Percentage Covered / Total
🟡 Statements 74.35% 6109/8217
🔴 Branches 50.87% 1352/2658
🔴 Functions 56.22% 895/1592
🟡 Lines 76.45% 5475/7162

Test suite run failed

Failed tests: 4/761. Failed suites: 1/120. 
  ● txSender › dispatchTxSigning › should sign a tx

    TypeError: Cannot set properties of undefined (setting 'timestamp')

      146 |     try {
      147 |       let signedTx = (await sdk.signTransaction(safeTx, signingMethod)) as EternalSafeTransaction
    > 148 |       signedTx.timestamp = safeTx.timestamp
          |                         ^
      149 |       return signedTx
      150 |     } catch (error) {
      151 |       const isLastSigningMethod = i === signingMethods.length - 1

      at tryOffChainTxSigning (src/services/tx/tx-sender/sdk.ts:148:25)
      at dispatchTxSigning (src/services/tx/tx-sender/dispatch.ts:31:16)
      at Object.<anonymous> (src/services/tx/tx-sender/__tests__/ts-sender.test.ts:213:24)

  ● txSender › dispatchTxSigning › should only sign with `eth_signTypedData` on older Safes

    TypeError: Cannot set properties of undefined (setting 'timestamp')

      146 |     try {
      147 |       let signedTx = (await sdk.signTransaction(safeTx, signingMethod)) as EternalSafeTransaction
    > 148 |       signedTx.timestamp = safeTx.timestamp
          |                         ^
      149 |       return signedTx
      150 |     } catch (error) {
      151 |       const isLastSigningMethod = i === signingMethods.length - 1

      at tryOffChainTxSigning (src/services/tx/tx-sender/sdk.ts:148:25)
      at dispatchTxSigning (src/services/tx/tx-sender/dispatch.ts:31:16)
      at Object.<anonymous> (src/services/tx/tx-sender/__tests__/ts-sender.test.ts:234:24)

  ● txSender › dispatchTxSigning › should only sign with `eth_signTypedData` for unsupported contracts (backend returns `SafeInfo['version']` as `null`)

    TypeError: Cannot set properties of undefined (setting 'timestamp')

      146 |     try {
      147 |       let signedTx = (await sdk.signTransaction(safeTx, signingMethod)) as EternalSafeTransaction
    > 148 |       signedTx.timestamp = safeTx.timestamp
          |                         ^
      149 |       return signedTx
      150 |     } catch (error) {
      151 |       const isLastSigningMethod = i === signingMethods.length - 1

      at tryOffChainTxSigning (src/services/tx/tx-sender/sdk.ts:148:25)
      at dispatchTxSigning (src/services/tx/tx-sender/dispatch.ts:31:16)
      at Object.<anonymous> (src/services/tx/tx-sender/__tests__/ts-sender.test.ts:255:24)

  ● txSender › dispatchTxSigning › should iterate over each signing method on newer Safes

    TypeError: Cannot set properties of undefined (setting 'timestamp')

      146 |     try {
      147 |       let signedTx = (await sdk.signTransaction(safeTx, signingMethod)) as EternalSafeTransaction
    > 148 |       signedTx.timestamp = safeTx.timestamp
          |                         ^
      149 |       return signedTx
      150 |     } catch (error) {
      151 |       const isLastSigningMethod = i === signingMethods.length - 1

      at tryOffChainTxSigning (src/services/tx/tx-sender/sdk.ts:148:25)
      at dispatchTxSigning (src/services/tx/tx-sender/dispatch.ts:31:16)
      at Object.<anonymous> (src/services/tx/tx-sender/__tests__/ts-sender.test.ts:278:24)

Report generated by 🧪jest coverage report action from c47140c

Please sign in to comment.