Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: add register_next_step_handler for asyncbot #2344

Conversation

hiddify-com
Copy link
Contributor

Description

create missing
register_next_step_handler in asyncbot using auto state

Describe your tests

run step_example.py in async_telebot

Python version:

OS:

Checklist:

  • [*] I added/edited example on new feature/change (if exists)
  • [*] My changes won't break backward compatibility
  • [*] I made changes both for sync and async

@coder2020official
Copy link
Collaborator

No

@hiddify-com
Copy link
Contributor Author

why?

@coder2020official
Copy link
Collaborator

  1. Bad implementation
  2. No steps in async please

@hiddify-com
Copy link
Contributor Author

It is based on your recommendation that suggest to use state

It is really useful to have steps in async

The step in sync is buggy also. It does not process middlewares.

@coder2020official
Copy link
Collaborator

Steps are an old, somewhat "deprecated"(though not yet and won't probably), so there's no point of improving them when there's a solution(states) which I am currently working on to even further improve

@hiddify-com
Copy link
Contributor Author

the problem of state is that we can not have more complex workflow
for example when we want to get 10 elements from user it is so hard to be implemented by state

@coder2020official
Copy link
Collaborator

What do you even mean by "10 elements"?
10 inputs?
I am working on an easier solution, some class that will take care of this

@hiddify-com
Copy link
Contributor Author

yes 10 inputs from the user

great thanks

@hiddify-com
Copy link
Contributor Author

@coder2020official Thanks for your great job. It would be great if we can have a timeline about your solution

@coder2020official
Copy link
Collaborator

Hi, my solution never came to existence, and I haven't had enough time recently either. I wouldn't mind re opening this.

I'm open to proposals, or I'll look at this issue again in December and see if there's any way I can simplify states logic.

Also, I have re implemented states to make them easier to use :)

@coder2020official
Copy link
Collaborator

I'll open an issue

@hiddify-com
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants