Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance optimisations of the geometry validation module (GmlGeoX) #57

Closed
jonherrmann opened this issue Jan 14, 2019 · 2 comments
Closed
Assignees
Labels
EIP-approved EIP approved by the Steering Group Impl. EIP has been implemented and is ready for the next release. Doc might be incomplete (temp. label)
Milestone

Comments

@jonherrmann
Copy link
Contributor

jonherrmann commented Jan 14, 2019

ETF Improvement Proposal (EIP)

Background and Motivation:

Large parts of the geometry validation module GmlGeoX have been rewritten to improve the validation performance, add new capabilities (e.g., for arcs) and improve the architecture / the maintainability of the code.

Proposed change

See https://github.com/interactive-instruments/etf-gmlgeox/blob/EIPs/EIP-57/Readme.md for a detailed specification of the new API.

Since the API of the module changes significantly and will not be compatible with existing ETSs, the proposal is to release the new version as a major release (version 2). As a result, both the old and new version of GmlGeoX could be provided with the ETF software (as long as both versions are compatible with the BaseX version used in an ETF release).

The version 1 module would still be usable when the namespace of GmlGeoX version 1 is used:

import module namespace ggeo='de.interactive_instruments.etf.bsxm.GmlGeoX'

The new module would get a new namespace:

import module namespace geox = 'https://modules.etf-validator.net/gmlgeox/2'

The library will be part of the BaseX testdriver, it will be integrated into the etf-bsxtd repository.

Alternatives

Support for version 1 could be removed.

Funding

Yes

Additional information

n/a

@jonherrmann jonherrmann added the EIP-draft Announcement. Will not be discussed further as long as the necessary information is available. label Jan 14, 2019
jonherrmann added a commit to interactive-instruments/etf-gmlgeox that referenced this issue Jan 14, 2019
EIP etf-validator/governance#57

Performance optimisations

BREAKING CHANGES: API changed

Co-authored-by: Johannes Echterhoff <echterhoff@interactive-instruments.de>
Signed-off-by: Jon Herrmann <herrmann@interactive-instruments.de>
@jonherrmann jonherrmann changed the title Performance optimisations of the geometry validation module (GmlGeoX) Performance optimisations of the geometry validation module (GmlGeoX) [DRAFT] Jan 14, 2019
jonherrmann added a commit to interactive-instruments/etf-bsxds that referenced this issue Jan 22, 2019
Required for EIP etf-validator/governance#57

Signed-off-by: Jon Herrmann <herrmann@interactive-instruments.de>
@cportele cportele added EIP Improvement Proposal. Put up for discussion. and removed EIP-draft Announcement. Will not be discussed further as long as the necessary information is available. labels Apr 24, 2020
@jonherrmann jonherrmann changed the title Performance optimisations of the geometry validation module (GmlGeoX) [DRAFT] Performance optimisations of the geometry validation module (GmlGeoX) May 6, 2020
@MarcoMinghini
Copy link
Member

SG meeting 24 (2020-08-06)
It is agreed to accept the EIP and move it under TC: scheduled for release in the EIP project board. The EIP will be included in the next release of the ETF.

The old version (v. 1) of the GmlGeoX module needs to be integrated with the new version of deegree, and this should be done in time for the next release. The approach for this integration should be discussed in a new EIP; once the approach is proven to work for v. 1 of GmlGeoX, in the future the same approach can be extended to v. 2.

@MarcoMinghini MarcoMinghini added EIP-approved EIP approved by the Steering Group and removed EIP Improvement Proposal. Put up for discussion. labels Sep 7, 2020
@jonherrmann jonherrmann added the Impl. EIP has been implemented and is ready for the next release. Doc might be incomplete (temp. label) label May 23, 2022
@jonherrmann
Copy link
Contributor Author

Implemented in Version 2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EIP-approved EIP approved by the Steering Group Impl. EIP has been implemented and is ready for the next release. Doc might be incomplete (temp. label)
Projects
None yet
Development

No branches or pull requests

4 participants