Fix get_pragma_spec() to exclude commented out pragma statements on compile #1552
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix get_pragma_spec() to exclude commented out pragma statements at the beginning of the file.
What I did
Refactor brownie/project/sources.py::
get_pragma_spec()
How I did it
Reconfigure regex to grab all
pragma solidity
statements in the file and then loop through and skip over any that are prefixed with a "//". Continue looping until first valid pragma statement is found.How to verify it
Wrote three new unit tests to look at scenarios where:
Checklist