Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.11 compatibility - upgrade yarl and set versions for bitarray #1655

Merged
merged 4 commits into from
Apr 24, 2023

Conversation

calina-c
Copy link
Contributor

@calina-c calina-c commented Jan 2, 2023

What I did

I encountered issues with Python 3.11 compatibility in a project using eth-brownie. I fixed the problem of dependencies and tested with a matrix strategy for python 3.8, 3.10 and 3.11 on ubuntu, mac and windows. The solution helped a lot and I thought to share it with brownie core :)

I've also seen this reported here: # and it should fix that too.

How I did it

Upgraded yarl and added version constraints for bitarray for compatibility with Python 3.11.

How to verify it

A pip install and running the tests should do it.

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have included test cases
  • I have updated the documentation
  • I have added an entry to the changelog

Not sure how the checklist applies but I'll see if any CI is triggered automatically and fill in the list if necessary.

Copy link
Collaborator

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems fine to me. is there any chance of compromise in any of the updated dependencies?

@calina-c
Copy link
Contributor Author

this seems fine to me. is there any chance of compromise in any of the updated dependencies?

I don't think so. Should I do a rebase?

@charles-cooper
Copy link
Collaborator

this seems fine to me. is there any chance of compromise in any of the updated dependencies?

I don't think so. Should I do a rebase?

no rebase required. thanks!

@charles-cooper charles-cooper merged commit 3b5f0ce into eth-brownie:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants