Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include encoded return data in transaction trace #1715

Merged

Conversation

sparrowDom
Copy link
Contributor

What I did

The transaction trace didn't include the encoded return value of function calls if there was no source code contact information. This PR always includes the return data (when not null). If contract source code information is available, the returndata gets overridden by return_value.

Related issue: #1360

How I did it

I've decoded the returndata in the loop that loops through the trace steps before it chooses to ignore a step that doesn't have contract source code information available.

How to verify it

Run call_trace(True) on any transaction. Example before:
Screenshot 2023-12-19 at 13 14 20
Example after (including this change):
Screenshot 2023-12-19 at 13 14 33

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have included test cases
  • I have updated the documentation
  • I have added an entry to the changelog

@iamdefinitelyahuman
Copy link
Member

Cool!

@iamdefinitelyahuman iamdefinitelyahuman merged commit 6879c9a into eth-brownie:master Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants