Include encoded return data in transaction trace #1715
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
The transaction trace didn't include the encoded return value of function calls if there was no source code contact information. This PR always includes the return data (when not null). If contract source code information is available, the
returndata
gets overridden byreturn_value.
Related issue: #1360
How I did it
I've decoded the
returndata
in the loop that loops through the trace steps before it chooses to ignore a step that doesn't have contract source code information available.How to verify it
Run
call_trace(True)
on any transaction. Example before:Example after (including this change):
Checklist