Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update repository layout #78

Merged
merged 2 commits into from
Jun 18, 2024
Merged

update repository layout #78

merged 2 commits into from
Jun 18, 2024

Conversation

arnetheduck
Copy link
Contributor

Make repository layout match https://github.com/eth-clients/mainnet:

  • remove deploy_block.txt (duplicate of deposit_contract_block.txt)
  • remove boot_enr.txt (duplicate of bootstrap_nodes.txt)
  • parsedBeaconState.json -> genesis.json
  • bepolia -> metadata

Make repository layout match https://github.com/eth-clients/mainnet:

* remove `deploy_block.txt` (duplicate of `deposit_contract_block.txt`)
* remove `boot_enr.txt` (duplicate of `bootstrap_nodes.txt`)
* `parsedBeaconState.json` -> `genesis.json`
* `bepolia` -> `metadata`
@barnabasbusa
Copy link
Collaborator

Could you please adjust the PR to revert the change from parsedBeaconState to leave it as is? (as also discussed on discord).

@arnetheduck
Copy link
Contributor Author

Could you please adjust the PR to revert the change from parsedBeaconState to leave it as is

thoughts on separate folders for el and cl? then each world can have its own names and formats

@barnabasbusa
Copy link
Collaborator

I'd be against it. We could rename it to literally anything else but genesis.json.

@arnetheduck
Copy link
Contributor Author

hm, in that case, I think it might be best to move it out of here altogether - ie the mainnet/holesky repos don't have it - I think it's mostly for informational purposes / easy grepping - might as well move it down one level since it's not part of official "metadata" - then there's no confusion as to what files must be here to launch a network

@barnabasbusa
Copy link
Collaborator

holesky doesn't have it because it would be like 2GB. Mainnet could have it.

@arnetheduck
Copy link
Contributor Author

holesky doesn't have it because it would be like 2GB. Mainnet could have it.

yes - the point is more that clients don't need the parsed version to start - the intent is for metadata to hold all information necessary but nothing else, so that it's unambiguous to implement - otherwise, we might get into silly out-of-sync issues between the two files, which is where this whole game started

@arnetheduck
Copy link
Contributor Author

ae686ec is the suggestion, concretely

@arnetheduck arnetheduck merged commit 0520de3 into main Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants