Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for ROCm backend of TiledMM. Blas backend selection is now a single option. #18

Merged
merged 4 commits into from
Nov 11, 2019
Merged

Added support for ROCm backend of TiledMM. Blas backend selection is now a single option. #18

merged 4 commits into from
Nov 11, 2019

Conversation

AdhocMan
Copy link
Contributor

@AdhocMan AdhocMan commented Nov 8, 2019 •
edited
Loading

TiledMM will have to be updated as well.

@AdhocMan AdhocMan changed the title Adds support for ROCm backend of TiledMM. Blas backend selection is now a single option. Added support for ROCm backend of TiledMM. Blas backend selection is now a single option. Nov 8, 2019
@kabicm kabicm self-requested a review November 8, 2019 13:42
@kabicm kabicm added the enhancement New feature or request label Nov 8, 2019
kabicm
kabicm reviewed Nov 8, 2019
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@AdhocMan
Copy link
Contributor Author

AdhocMan commented Nov 8, 2019

There is now a COSMA_BLAS and COSMA_SCALAPACK option, which have to match for the non-GPU case.

@kabicm
Copy link
Collaborator

kabicm commented Nov 9, 2019

Looks great now, thanks @AdhocMan ! If @rasolca also agrees, I think we can merge this PR.

@kabicm kabicm merged commit 52ee923 into eth-cscs:master Nov 11, 2019
@fstein93 fstein93 mentioned this pull request Jul 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kabicm kabicm kabicm left review comments

@rasolca rasolca rasolca left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdhocMan @kabicm @rasolca