Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable MPI pool on all CIs #1224

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Enable MPI pool on all CIs #1224

wants to merge 1 commit into from

Conversation

rasolca
Copy link
Collaborator

@rasolca rasolca commented Dec 2, 2024

No description provided.

@rasolca rasolca requested review from msimberg and biddisco December 2, 2024 15:53
@rasolca
Copy link
Collaborator Author

rasolca commented Dec 2, 2024

cscs-ci run

@rasolca rasolca self-assigned this Dec 2, 2024
@msimberg
Copy link
Collaborator

msimberg commented Dec 2, 2024

Any particular reason? Debugging? Consistency? I have nothing much against this, but just looking to understand the reasoning (as I think it can be good to test with it both on and off).

@rasolca
Copy link
Collaborator Author

rasolca commented Dec 3, 2024

Noticed during rebase of #1192 that pool was enabled only on CUDA pipelines with no clear reason.

IMO:

  • Default behavior should be with pool.
  • If we want to test without pool we can add or modify some pipeline (and should be tested on both mc and gpu)

msimberg
msimberg requested changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already discussed separately with @rasolca, but making the request explicit: I'd like to keep at least one CI configuration with the pool disabled just as a sanity check, since the pool is off by default.

@msimberg msimberg marked this pull request as draft March 24, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg requested changes

@biddisco biddisco Awaiting requested review from biddisco

Requested changes must be addressed to merge this pull request.

Assignees

@rasolca rasolca

Labels
Category:CI Priority:Medium
Projects
DLA-F Planning
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rasolca @msimberg