-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReductionToBand, BTReductionToBand, TFactor: Taus on GPU #1304
base: master
Are you sure you want to change the base?
Conversation
88d18f2
to
be2447d
Compare
be2447d
to
ccdc587
Compare
ccdc587
to
9fd1819
Compare
cscs-ci run |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1304 +/- ##
=======================================
Coverage 95.07% 95.07%
=======================================
Files 141 141
Lines 8654 8656 +2
Branches 1110 1110
=======================================
+ Hits 8228 8230 +2
Misses 239 239
Partials 187 187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea about performance changes? Should have no effect, but have you tested if that's the case?
It's a good point. I still have it in my plan, but before doing that I'm double checking HMM Heterogenous Memory Management 😉 Let me add a todo/reminder in the PR 😉 |
The target of this PR is moving TAUS from being stored on CPU to be stored on GPU memory.
It's more a cleanup than an optimisation.
Changelog:
ComputePanelHelper<GPU>::mat_taus_cpu
).private
, thatloop_gemv
andloop_trmv
are internal functions. These clarifies that these functions might have different signatures between the two different backends. Actually, in GPU version ofloop_gemv
,taus
parameter was superfluous so it has been dropped now.TODO