-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restapi 1453 commands log #23
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_FILE to heml chart.
Cleanup of settings import (to be verified). Renamed debug_log into f7tlog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes with description:
Upgraded existing JSON logger to
f7t_tracing_log
features:middleware
) and command execution (SSH, filesystem, scheduler);f7t_tracing_log
and it is returned in the header section of the response to the user. The ID allow to trace all the log events invoked for a single request, whatever they are;f7t_tracing_log
can be enabled or disabled in the standard F7Tv2 configuration file, I created a section with the related classes. I tried to access the configuration directly from the logger module, but due some "circular imports" errors, I should revert that to explicitly configure the logger with an initialization function called inmain.py
.Added new general-purpose/debugging log f7tlog:
F7TLOG
independently from the Uvicorn logs;Loggers configuration file:
/build/environment/firecrest-api-config/log-config.yaml
embedded into the Dockerfile. It can however be overwritten at deploy time, or changed at build timeDuring the work, I found some tests failing because of errors with "Circular module import". After some debugging, I found a way to solve this, but I also noticed that there was some duplication with
firecrest.config import Settings
vsfirecrest.plugin import settings
in bothmain.py
andtests/conftest.py
. I tried to cleanup the duplication using the same approach used for any routers. Now they should be aligned, but actually I don't know if that matches the architectural choices.Thank you.