Return with error code 408 when basic commands timeout on the cluster #24
Conversation
| @@ -34,6 +34,11 @@ def error_handling(self, stderr: str, exit_status: int): | |||
| if len(stderr) > 0: | |||
| error_mess += f" and error message:{stderr.strip()}" | |||
|
|
|||
| if exit_status == 124: | |||
There was a problem hiding this comment.
This assumption exit_status:124 = Timeout is only true if the the command was executed with timeout in front.
The base_command_error_handling has no way to know if that was the case.
I believe the proper solution would be to implement a new class BaseCommandWithTimeout and BaseCommandWithTimeoutErrorHandling that extends BaseCommand and ensures all commands are executed with a timeout. Meaning the assumption above would always be true.
Alternatively we should state the assumption in a comment in the above code.
There was a problem hiding this comment.
p.s. my preference is to simply add a comment and state the assumption.
There was a problem hiding this comment.
Oh, sorry, I have already merged but I can fix it in another PR! :)
If I remember right, FirecREST runs every command with a timeout, right? I will check the code and see if we use it for a different case too. I can add the comment anyway
Fixes RESTAPI-1462.