Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restapi 1465 add UI to demo image #26

Merged
merged 13 commits into from
Mar 12, 2025
Merged

Conversation

theely
Copy link
Collaborator

@theely theely commented Mar 12, 2025

Adds Firecrest Web UI to the Demo image

Copy link
Collaborator

@francescopagnamenta francescopagnamenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this minimal OAuth2 Authorization Code Flow implementation, and I believe it would be beneficial to externalize it as a separate component/image to enable reuse across different projects.

Copy link
Collaborator

@francescopagnamenta francescopagnamenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theely theely merged commit e74125c into master Mar 12, 2025
2 checks passed
@theely theely deleted the RESTAPI-1465-add-UI-to-demo-image branch March 12, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants