Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: actually create/delete HSM groups without crashing #17

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Fix: actually create/delete HSM groups without crashing #17

wants to merge 9 commits into from

Conversation

miguelgila
Copy link
Collaborator

  • Prevent that when some optional fields are empty, Mesa sends unacceptable JSON content to HSM
  • When creating a new HSM group, CSM returns a text field, not a json. This made the function always fail, even when the creation was done successfully.

@miguelgila
Fix: actually create hsm groups without crashing
09fccf9 
* prevent some optional fields are empty from crashing
* CSM returns a text, not a json field
@miguelgila
actually handle return message from CSM when deleting an HSM group
d034923
@miguelgila miguelgila changed the title Fix: actually create hsm groups without crashing Fix: actually create/delete HSM groups without crashing May 27, 2024
@miguelgila
Copy link
Collaborator Author

Still working on this, please do not merge yet, I keep finding errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@miguelgila