Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor fixes and cleanups #212

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

albestro
Copy link
Contributor

@albestro albestro commented Feb 28, 2025

Changelog:

  • remove hard-coded variants (not used, templates ones are)
  • remove duplicated target from Makefile.compilers (70f1ebb)
  • added ruff to pyproject.toml
  • some formatting and typos fixing

About first point, I currently went for enabling gcc +profiled in the template as it was in the unused hard-coded variants, just because it sounds like a good thing. I'm not sure how much difference it will make, but it can make a difference in terms of cache reuse for future uenv builds. Indeed, AFAICT, spack info gcc reports

Variants:
...
    bootstrap [true]                   false, true
        Enable 3-stage bootstrap
...
    when %gcc+bootstrap
      profiled [false]                 false, true
          Use Profile Guided Optimization

which means that before this PR stackinator was configuring the bootstrapped compiler as gcc+bootstrap~profiled and now it should (implicitly) become gcc+bootstrap+profiled.

Waiting for your comments about this decision, which we can easily revert and keep the bootstrapped compiler as gcc+bootstrap~profiled.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
according to section "Building with profile feedback" in https://gcc.gnu.org/install/build.html

> It is possible to use profile feedback to optimize the compiler itself.
> This should result in a faster compiler binary.
> Experiments done on x86 using gcc 3.3 showed approximately 7 percent speedup on compiling C programs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant