Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bash completion #58

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

bash completion #58

wants to merge 32 commits into from

Conversation

rjanalik
Copy link
Contributor

No description provided.

@rjanalik rjanalik force-pushed the feature/bash-completion branch from bc3db30 to db9077f Compare February 18, 2025 14:17
@rjanalik rjanalik force-pushed the feature/bash-completion branch from db9077f to d3cd2c2 Compare February 18, 2025 14:20
@rjanalik rjanalik force-pushed the feature/bash-completion branch from b2e1059 to 2e49f41 Compare February 18, 2025 23:01
@rjanalik rjanalik force-pushed the feature/bash-completion branch from 2e49f41 to f725244 Compare February 18, 2025 23:11
@rjanalik rjanalik force-pushed the feature/bash-completion branch from c42d470 to 6d815ef Compare February 25, 2025 18:49
bcumming
bcumming requested changes Feb 27, 2025
View reviewed changes
Copy link
Member

@bcumming bcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small fixes.

To create the completions, use a sub-command instead of a flag:

uenv completion bash

This fits the uenv <verb> <options> model. Flags like --verbose or --color are optional information that influence actions.

rjanalik
rjanalik commented Mar 1, 2025
View reviewed changes
bcumming
bcumming requested changes Mar 2, 2025
View reviewed changes
@rjanalik rjanalik force-pushed the feature/bash-completion branch from 3079e14 to 13a4a88 Compare March 2, 2025 20:58
@rjanalik rjanalik marked this pull request as ready for review March 4, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcumming bcumming bcumming requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjanalik @bcumming