add postOp param (gasPrice) #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saves TokenPaymaster 731 gas (it currently required to pass maxFeePerGas and maxPriorityFee as context params) add "plain postOp" (which ignores this param) 24 gas.
shahafn
previously approved these changes
Jan 7, 2024
forshtat
requested changes
Jan 8, 2024
contracts/core/BasePaymaster.sol
Outdated
| @@ -54,10 +54,11 @@ abstract contract BasePaymaster is IPaymaster, Ownable { | |||
| function postOp( | |||
| PostOpMode mode, | |||
| bytes calldata context, | |||
| uint256 actualGasCost | |||
| uint256 actualGasCost, | |||
| uint gasPrice | |||
There was a problem hiding this comment.
This name is highly confusing. The postOp method can actually call tx.gasprice and developers will be confused with the fact they are not the same thing. We should name it actualUserOpFeePerGas or something like that, so that the name "screams" that this is not tx.gasprice.
Also, please, use uint256 for both params - makes no sense to use two different ways in one line.
| @@ -102,11 +102,11 @@ contract LegacyTokenPaymaster is BasePaymaster, ERC20 { | |||
| * the user's TX , back to the state it was before the transaction started (before the validatePaymasterUserOp), | |||
| * and the transaction should succeed there. | |||
| */ | |||
| function _postOp(PostOpMode mode, bytes calldata context, uint256 actualGasCost) internal override { | |||
| function _postOp(PostOpMode mode, bytes calldata context, uint256 actualGasCost, uint gasPrice) internal override { | |||
There was a problem hiding this comment.
Unrelated - why do we keep this old code around? Can we remove it?
| address userOpSender | ||
| ) = abi.decode(context, (uint256, uint256, uint256, address)); | ||
| uint256 gasPrice = getGasPrice(maxFeePerGas, maxPriorityFeePerGas); | ||
| ) = abi.decode(context, (uint256, address)); |
There was a problem hiding this comment.
This means the entire getGasPrice function is no longer needed - please remove.
so we don't confuse userop-specific gasPrice with tx.gasprice
drortirosh
force-pushed
the
postOp-gas-price
branch
from
3e567aa
to
8faf84a
Compare
shahafn
approved these changes
Jan 9, 2024
forshtat
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
saves TokenPaymaster 731 gas (it currently required to pass maxFeePerGas and maxPriorityFee as context params)
add "plain postOp" (which ignores this param) 24 gas.