Use parameter for nocolor

[esetera]

It would be good to have a parameter to turn off the colors by default

[bingjie2680]

at least should assign very light colour for authors, because dark colour causes readability issues.

[JohnMcLear]

Do you want the author to not be able to see their colour AND do you want the viewer to not be able to see?

Do you want the user to be able to toggle this value or do you want this value to be set at a "pad" level?

[JohnMcLear]

Currently I'm thinking I will pass &noColor=true and it will just hide all backgrounds colors. Should be easy"ish" to do.. Will take a look

[JohnMcLear]

https://github.com/johnyma22/etherpad-lite/commit/1bfd0e470760e7e29bcfbe60c9578915c102576a

[jeff-h]

I hadn't realised this issue was here, so put something very similar at t https://github.com/Pita/etherpad-lite/issues/151#issuecomment-1989531 — my personal preference / use case would be for nobody to see colours just like you've implemented... thanks!

However perhaps a nice feature would be to allow each user to decide for themselves whether they will have a colour, or no colour, on a personal basis. Thus you could had a colour, and I could have none, and I would see your edits in your colour. I am sure that's more complex to code though! :)

[JohnMcLear]

Well the ?noColor param is afaik per user :)

[jeff-h]

Sorry, I meant per user as in I could have a colour, and you could have none, and when we each look at our respective browser's copies of the document, we will both see my edits in my colour, and yours in none.

[JohnMcLear]

so I understand this as "Everyone else has no color". Will take a goosey.

[jhollinger]

I would expect a noColor param to simply "hide" the colors in that window only. Everyone else would see the colors, including the color of the person who's hiding the colors. In other words it's just a view option. Actually it might make a nice Hide Authorship Colors button - an alternative to Clear Authorship Colors?

[JohnMcLear]

You can do this with a parameter. ?noColors=true

-----Original Message-----
From: Jordan Hollinger [mailto:reply@reply.github.com]
Sent: 04 December 2011 18:02
To: John McLear
Subject: Re: [etherpad-lite] Use parameter for nocolor (#126)

I would expect a noColor param to simply "hide" the colors in that window only. Everyone else would see the colors, including the color of the person who's hiding the colors. In other words it's just a view option. Actually it might make a nice Hide Authorship Colors button - an alternative to Clear Authorship Colors?

---

Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/issues/126#issuecomment-3007768
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools

[Pita]

everyone else has no color just confuses the user and has no benefit at all imho

[jhollinger]

IMHO, the existing noColor option is sufficient. Sure, there are plenty of other color/no-color options we could imagine, but are they useful enough to outweigh the potential ambiguity and confusion?

[JohnMcLear]

Just to add my 2 pence as the person doing the dev on this. Actually making this change is proving to be pretty difficult, not sure if I'm missing something..

I know where and what to do but it feels dirty.

-----Original Message-----
From: Jordan Hollinger [mailto:reply@reply.github.com]
Sent: 04 December 2011 19:04
To: John McLear
Subject: Re: [etherpad-lite] Use parameter for nocolor (#126)

IMHO, the existing noColor option is sufficient. Sure, there are plenty of other color/no-color options we could imagine, but are they useful enough to outweigh the potential ambiguity and confusion?

---

Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/issues/126#issuecomment-3008109
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools

[JohnMcLear]

I just pushed this back to 1.2

[marcelklehr]

close this, pls.

[JohnMcLear]

I'm not sure this can be closed? Afaik they want different functionality.

[marcelklehr]

yeah, but that's not the subject of the issue, here...