-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve accessibility for blind people and other users of screen readers #1803
Comments
you can do text to speech and speech to pad |
@lizzard did you get chance to try out ep_themes? |
I will not have a chance for another week or so, but thank you for the idea John! I'm not sure what the exact issues are but maybe can work with others to collect info on what makes it so unworkable at the moment (compared to other collaborative editors) |
Hi John, could you elaborate on what you mean by "you can do text to speech"? Of course screen readers already employ TTS as part of their solution - is this what you mean - or do you mean that there is some TTS option built into etherpad-lite (which would make it a "self-voicing" app in accessibility terms)? I may be able to help with this issue but I want to make sure I fully understand the current status of things. |
Ah if your screen reader already does it then just ignore me :) |
:) So I think Lizzard filed this issue because existing screen readers can't currently work well with etherpad. The problem is that browsers are exposing the DOM structure and mutations but they are atypical for text areas/editors so the screen reader can't correctly make sense of them. The work to fix this would likely involve similar work to what they did in the orion editor (I have contacts)... |
What changes would be necessary to allow people behind screen readers to (Or rather: What are screen readers capable of in terms of web technology?) |
I don't know the details and am not a screen reader user. But have had reports from friends who are blind and use screen readers that Etherpad is not accessible for them. For me this is a problem because it's a collaboration tool that we use often at work at Mozilla! I love Etherpad, and was using it for bug triage meetings --- but unless it's useable for screen readers I don't want to leave out any of my community. So, I've been using wiki pages or Google Docs instead. I would be happy to work with dbolter to try to find testers or developers at least to report or explain what doesn't work as well as to outline what might be done to fix the DOM structure for screen reader navigation. |
Hi all! To re-kindle this: The markup inserted into the contentEditable that is the text area must be compliant. So if somebody formats something as an ordered list, an ol and li elements must be inserted. Same for headings: A heading of a certain type is h1 through h6. Paragraphs are p elements etc. |
As an FYI, here's some info on how Google Docs handles accessibility |
Preface: I am sighted and have not used a screen reader. My interest is in how it scales. It's chaotic visually, but a reader sounds even more so. It seems like it would be fine being between two people, but exponentially crazier after that, largely due to the limits of the reader. |
Hey guys, I have been tasked with working on this so if anyone can jump in and help please say! :) |
Hi John. I'm definitely interested in working on this. I'm swamped at work for the next week or so, but might have some time to help after that. I have no knowledge of the Etherpad code base, but, as a user, I do have some ideas on how to improve its accessibility. One suggestion I'd make is to first worry about the single user case (saving the live collaboration case for the second phase.) Even though one of Etherpad's major features is collaboration, I suspect there are plenty of folks that use it, at least some of the time, alone. There are also some relatively "low hanging fruit" for the single user case. If you like, I can try to put together a quick list now or a more reasoned and thoughtful list next week. |
Some initial thoughts:
Those are probably the low hanging fruit. Beyond that, there are a couple of broader areas that hinder accessibility:
|
All duly noted and added to my pad. I have a branch with the support in now: https://github.com/ether/etherpad-lite/tree/editbar-accessibility -- Accessing and navigating the editbar with the keyboard is now possible. My notes and to do list is at: http://john.primarypad.com/ogf-24-03-15 |
Okay guys I did what I could this week. Accessibility enabled version of Etherpad at http://beta.etherpad.org What have we missed? Please have a play and let me know! |
Heh guys I think it's amazing. I have created an example pad with my comments. Once it disappears I can restore it later from a backup. Edit: The major issues is that I don't know how to manipulate the timeline slider. Other than this I have only found some minor issues so far. |
@pvagner Excellent thank you so much for this! |
@pvagner et al, this is ready for further testing. Accessibility enabled version of Etherpad at http://beta.etherpad.org |
Hello, |
@pvagner thanks, Timeslider should just be able to play back the pad... Visit https://beta.etherpad.org/p/foo/timeslider#0 and try to use that page.. Does that work for you? |
Thank you for the explanation and a test pad. I have finally got the idea hopefully. |
Hrm, well yeah regarding the timeslider experience, it's tricky because I wouldn't know what content to read to a screen reader.. I guess we could have an aria content section on the pad contents in the timeslider and make it read that contents on each forward/backwards but that's going to be a horrible UX for a screen reader? I did look at other slider options, they don't really "fit" into what we're doing, our slider has to be designed in such a way that we will be able to overlay contents onto it in the future (a feature I want to work on) and as such we need to stick with our current solution.. It would however be useful to have an aria notification on slider move that notifies the user of their new location in the pad IE the date/time and the revision. I will add these bits to do my todo list :) I have received some comments but until it's merged into a release branch they are only dripping in slowly! |
This is now merged into Develop and will be released into master shortly :) Enjoy folks! Donations welcome! http://etherpad.org |
Should this be available on the Sandstorm demo? I'm blind and just tried this. The edit area is nicely accessible, but the toolbar is a bunch of unlabeled buttons/links. Arrowing through just says "button button button link clickable clickable clickable"... Nice work so far! |
Should this be available on the Sandstorm demo? I'm blind and just tried this. The edit area is nicely accessible, but the toolbar is a bunch of unlabeled buttons/links. Arrowing through just says "button button button link clickable clickable clickable"... Nice work so far! Edit: Ah, I see the issue. Toolbar buttons read when tabbed through, but not when arrowed past. It might be wise to use aria-label rather than the title attribute for those, as that should address both use cases. See this thread on the Discourse forum for more details: https://meta.discourse.org/t/accessibility-software-and-discourse/13711/21 |
Good question, I'd check with the sandstorm guys! @kentonv On 26 Jun 2015 17:10, Nolan Darilek notifications@github.com wrote: Should this be available on the Sandstorm demo? I'm blind and just tried this. The edit area is nicely accessible, but the toolbar is a bunch of unlabeled buttons/links. Arrowing through just says "button button button link clickable clickable clickable"... Nice work so far! — |
Check out my edit below. Looks like all the controls use `title` rather
than `aria-label`. They work fine if I tab between them, but not so well
if I arrow through the controls outside of the edit field. Should be a
pretty simple fix.
Thanks!
|
I think that Etherpad in Sandstorm should be the same accessibility-wise as Etherpad outside of Sandstorm. Of course, Sandstorm itself introduces an additional top bar with some more buttons, and we haven't had a chance to think about accessibility yet (in fact, the UI is still pretty bad even for those who can see). |
Hrm do you have the same experience on beta.etherpad.org ? On 26 Jun 2015 19:17, Kenton Varda notifications@github.com wrote: I think that Etherpad in Sandstorm should be the same accessibility-wise as Etherpad outside of Sandstorm. Of course, Sandstorm itself introduces an additional top bar with some more buttons, and we haven't had a chance to think about accessibility yet (in fact, the UI is still pretty bad even for those who can see). — |
Sorry, the reference to Sandstorm was a bit of a red herring. I'd tried
it in Sandstorm and had assumed that maybe the version Sandstorm shipped
might be lagging behind the released version, but it looks pretty
up-to-date. The issue isn't Sandstorm, it's just the use of the title
attribute rather than aria-label. Sandstorm itself is already pretty
accessible, but that's tangential to this issue. :)
|
Yes, because it still uses the same code. I.e.:
buttonicon-insertunorderedlist" data-l10n-id="pad.toolbar.ul.title" title="Unordered What you need is:
buttonicon-insertunorderedlist" data-l10n-id="pad.toolbar.ul.title" Or possibly both the title and aria-label attributes. Please see the The second is a bit non-standard. I can arrow through the controls as if The way to fix this is to use aria-label instead of, or in addition to, Thanks. |
Very useful I will do this tonight and update beta.etherpad.org for you to review :) thanks man! On 26 Jun 2015 19:30, Nolan Darilek notifications@github.com wrote: What you need is: Or possibly both the title and aria-label attributes. Please see the The second is a bit non-standard. I can arrow through the controls as if The way to fix this is to use aria-label instead of, or in addition to, Thanks. — |
having some issues with this will try finish over weekend From: Nolan Darilek [notifications@github.com] Yes, because it still uses the same code. I.e.: What you need is: Or possibly both the title and aria-label attributes. Please see the The second is a bit non-standard. I can arrow through the controls as if The way to fix this is to use aria-label instead of, or in addition to, Thanks. — |
Resolved #2711 |
Might there be some ways to usefully improve Etherpad Lite's accessibility? I know that people who browse with a screen reader can't use it. Etherpad is so useful that I hate to turn away from it as a collaboration tool. Is this something you have discussed already in issues or in a forum? I looked, but didn't find anything. If I can help gather suggestions I'm happy to do that.
The text was updated successfully, but these errors were encountered: