3 Firefox Javascript errors: (1) "info is null" /minified/pad.js line 2493 ; (2) syntax error /socket.io/1/xhr-polling/ "1" (3) syntax error /jserror "OK"

[Wikinaut]

In Firefox there's are these error messages:

(1)
Error: info is null
Source: http://beta.etherpad.org/minified/pad.js
Zeile: 2493

(2)
Error: Syntax error
Quelldatei: http://beta.etherpad.org/socket.io/1/xhr-polling/1490956074432109169?t=1322639214850
Line: 1, Column: 1
Source:
1

(3)
Syntax error line 1
beta.etherpad.org/jserror
OK

[Wikinaut]

Can someone with Firefox confirm my observations regarding the Javascript errors ?

[crash-dive]

Firefox does the same for me. It seems to be caused only when the property "grayedOut" is being set. However I have never come across that property before so I do not know what it does.

The error is not just in FF, I opened Chrome and looked and info is null when grayedOut is being set there as well, it is just no error is thrown to the console.

[Pita]

@ja-jo what is grayedOut?

[crash-dive]

Sorry should have given a little more info, I will do my best but I am still not 100% on how all the editor works.

The error Wikinaut is talking abouts comes during initialisation of the info object in pad.js. This object is created on line 2403 by calling the Ace2Editor function and is then used by a lot of functions via closure scoping.

However on line 1301 the function padeditor.disable calls editor.setProperty (grayedOut", true) this function then in turn calls info.ace_setProperty found on line 2493 (note we have now hit the info object). However this is done before the function Ace2Editor is called, meaing that info has not been set and therefore a null error is thrown to the console.

I hope that helps explain a little better what is going on.

[JohnMcLear]

Looking into this as my next job.

[JohnMcLear]

Quick fix for the "info" error
https://github.com/johnyma22/etherpad-lite/commit/0810915f2c708b54b93dda0ab5364242679a4aef &
https://github.com/johnyma22/etherpad-lite/commit/2038659ac71a9053b2e3ffbe3d336ce7de93df44

Looking at the Syntax error next, note, can't replicate this error, I think Pita might of fixed this one. So if @Pita merges the two commits above it should stop you seeing any errors.

Someone should probably look to see why the setProperty stuff is firing too early though, I don't know my way around that process to help.

[Wikinaut]

The info error (1) is unfortunately still present (the other errors (2) and (3) in my list disappeared). (Firefox)

Fehler: info is null
Quelldatei: https://pad.opteryx.org/minified/pad.js
Zeile: 2497

[JohnMcLear]

I can confirm this is still an issue

[marcelklehr]

I'm using FF10 and see no errors on the console...

[Wikinaut]

this is an old report. Will checkout with the latest revision and then probably close this issue, depending on my observations.

[Wikinaut]

Yes, still one error.

Error: illegal character
Source: https://pad.server.com/minified/pad.js Line 1

This file starts that way:

require.define({"/pad.js": (function (require, exports, module) {/**

• This code is mostly from the old Etherpad. Please help us to comment this code.
• This helps other people to understand this code better and helps them to improve it.
• TL;DR COMMENTS ON THIS FILE ARE HIGHLY APPRECIATED
  */

[Wikinaut]

perhaps the comment should be placed outside the require.define

[cweider]

@Wikinaut, what happens if the comment is removed? The line number may not be reliable, IIRC, errors that occur when the editor iframe is written can be very misleading. Also, while this is a problem, I’m guessing it’s unrelated to this issue, separate ticket?

[JohnMcLear]

Do we have a reliable way to consistently reproduce this bug?