The "star" button disappears for all pads after visiting a readonly pad #3702
Comments
babu15
changed the title
|
Good catch. Confirmed. Little star is "saved revision" and it's hidden server side, you gotta restart instance to get it back! Pretty serious imho. |
muxator
pushed a commit
to JohnMcLear/etherpad-lite
that referenced
this issue
Mar 19, 2020
…only pad This change adds again the saved revision button to the toolbar. Fixes ether#3702
muxator
pushed a commit
to JohnMcLear/etherpad-lite
that referenced
this issue
Mar 19, 2020
…only pad In theory visiting an unrelated read only pad should not cause effects on all the other pads. This change is a quick fix that adds back the "star" button to the toolbar if it's not already there. Fixes ether#3702
muxator
changed the title
muxator
pushed a commit
to JohnMcLear/etherpad-lite
that referenced
this issue
Mar 19, 2020
…only pad Before this patch, visiting the read-only URL for a random pad would remove the "Save Revision" (the "star" icon) from all the other RW pads. The only way to make it appear again was to restart the server. This change does not fix the underlying bug: after visiting a read only link the "star" button would still disapper, but it is explictly reinserted via an ad-hoc condition. Fixes ether#3702
muxator
pushed a commit
that referenced
this issue
Mar 19, 2020
…only pad Before this patch, visiting the read-only URL for a random pad would remove the "Save Revision" (the "star" icon) from all the other RW pads. The only way to make it appear again was to restart the server. This change does not fix the underlying bug: after visiting a read only link the "star" button would still disapper, but it is explictly reinserted via an ad-hoc condition. Fixes #3702
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When I use a read-only link the little star-icon disappears. It does not just disappear from one pad. All the old pads and all the newly generated pads no longer have the star in the toolbar.
When I restart the etherpad-service the little star appears again.
The text was updated successfully, but these errors were encountered: