Windows package is now broken

[JohnMcLear]

[2012-02-27 19:26:49.644] [INFO] http - 200, GET /static/img/etherpad_lite_icons.png
[2012-02-27 19:26:49.691] [ERROR] console - TypeError: Object.keys called on non-object
    at Function.keys (native)
    at ServerResponse. (C:\Users\john\Downloads\etherpad-lite-win (6)\etherpad-lite-win\node\utils\caching_middleware.js:90:18)
    at ServerResponse._implicitHeader (http.js:796:8)
    at ServerResponse.end (http.js:653:10)
    at ServerResponse. (C:\Users\john\Downloads\etherpad-lite-win (6)\etherpad-lite-win\node_modules\log4js\lib\connect-logger.js:73:7)
    at next (C:\Users\john\Downloads\etherpad-lite-win (6)\etherpad-lite-win\node_modules\express\node_modules\connect\lib\http.js:172:13)
    at next (C:\Users\john\Downloads\etherpad-lite-win (6)\etherpad-lite-win\node_modules\express\node_modules\connect\lib\http.js:205:9)
    at [object Object].handle (C:\Users\john\Downloads\etherpad-lite-win (6)\etherpad-lite-win\node_modules\yajsml\server.js:262:9)
    at Object.handle (C:\Users\john\Downloads\etherpad-lite-win (6)\etherpad-lite-win\node_modules\express\node_modules\connect\lib\http.js:105:14)
    at next (C:\Users\john\Downloads\etherpad-lite-win (6)\etherpad-lite-win\node_modules\express\node_modules\connect\lib\http.js:203:15)

NetworkError: 404 Not Found - http://127.0.0.1:9001/static/js/require-kernel.js"
require-kernel.js
"NetworkError: 500 Internal Server Error - http://127.0.0.1:9001/minified/pad.js?callback=require.define"
pad.js....define
"NetworkError: 500 Internal Server Error - http://127.0.0.1:9001/minified/pad.js?callback=require.define"
pad.js....define
require is not defined
[Break On This Error]   

require.setRootURI("../minified/");

[cweider]

Looks like internal requests (added in #468) are strange in Windows, will be looking into it more tomorrow. A revert of the merge may make sense, I don’t know if it’s an easy fix or not.

[Pita]

Its not the end of the world if the windows package is broken for a few days. I don't want to revert cause there will be a huge change comming in over the next days (plugin framework) and this will make it very difficult for you to commit your changes again

[JohnMcLear]

I agree.

-----Original Message-----
From: Peter 'Pita' Martischka [mailto:reply@reply.github.com]
Sent: 28 February 2012 13:37
To: John McLear
Subject: Re: [etherpad-lite] Windows package is now broken (#513)

Its not the end of the world if the windows package is broken for a few days. I don't want to revert cause there will be a huge change comming in over the next days (plugin framework) and this will make it very difficult for you to commit your changes again

---

Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/issues/513#issuecomment-4215785
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools

[JohnMcLear]

Had 2 people report this bug to me today, just FYI it looks like windows users are actually using the package quite a lot ;\

[cweider]

It should be working now.

[JohnMcLear]

Think I'm waiting for the package to rebuild, will test 2mrw.

[cweider]

NP.

[JohnMcLear]

@cweider the package is still broken

JxN4TMqPWy:1Uncaught ReferenceError: require is not defined
ace2_inner.js:1Uncaught ReferenceError: require is not defined
JxN4TMqPWy:2Uncaught ReferenceError: require is not defined

[notpeelz]

I'm having a similar issue; when I try to create a new pad, the web interface refuses to load even after using a freshly deployed version.
Also, once I restart the server after a pad has been created and then try to access it again, the following errors show up:
[2012-03-05 17:38:30.799] [INFO] console - Your Etherpad Lite git version is 6fd73ec
[2012-03-05 17:38:30.804] [INFO] console - Report bugs at https://github.com/Pita/etherpad-lite/issues
[2012-03-05 17:38:31.171] [INFO] console - Server is listening at 0.0.0.0:9001
[2012-03-05 17:38:31.172] [INFO] console - info - 'socket.io started'
[2012-03-05 17:38:38.553] [INFO] http - 200, GET /
[2012-03-05 17:38:38.616] [INFO] http - 404, GET /static/custom/index.css
[2012-03-05 17:38:38.619] [INFO] http - 404, GET /static/custom/index.js
[2012-03-05 17:38:39.989] [INFO] http - 200, GET /p/MVTnSfDf52
[2012-03-05 17:38:40.063] [INFO] http - 404, GET /static/custom/pad.css
[2012-03-05 17:38:40.066] [INFO] http - 200, GET /static/js/require-kernel.js
[2012-03-05 17:38:40.098] [INFO] http - 200, GET /static/css/pad.css
[2012-03-05 17:38:40.114] [INFO] http - 200, GET /static/img/leftarrow.png
[2012-03-05 17:38:40.117] [INFO] http - 200, GET /static/img/loading.gif
[2012-03-05 17:38:40.123] [INFO] http - 404, GET /static/custom/pad.js
[2012-03-05 17:38:40.138] [INFO] http - 200, GET /static/img/etherpad_lite_icons.png
[2012-03-05 17:38:40.263] [INFO] http - 404, GET /static/custom/pad.js
[2012-03-05 17:38:40.352] [INFO] http - 404, HEAD /static/js/jquery/index.js
[2012-03-05 17:38:40.360] [INFO] http - 404, GET /static/js/jquery/index.js
[2012-03-05 17:38:40.372] [INFO] http - 200, GET /minified/jquery/index.js?callback=require.define

[ghost]

Same here (like Chuiby) PUSH!!!

[JohnMcLear]

@cweider any update on this? Package still broken

[Pita]

@cweider has already a fix for that. We just can't merge it at the moment. But I updated the zip so it includes this patch. So the public download should work now again

Problem is that I had to disable the automatic build every 6 hours, someone needs to remind me to enable this again once we fixed that bug

[JohnMcLear]

Tested Okay