Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional QR code / third party service #564

Closed
payload opened this issue Mar 19, 2012 · 7 comments
Closed

optional QR code / third party service #564

payload opened this issue Mar 19, 2012 · 7 comments

Comments

@payload
Copy link

payload commented Mar 19, 2012

I replaced the QR code generator link for readonly pages with this image http://memegenerator.net/instance/16615378

The QR code generator is a Google service. I think using a third party service for something should be disabled by default, but easily enabled via the config file or even configurable by making the URL a config variable. Third party services shouldnt get a hint where to find high quality information about people via readonly etherpad pages. And etherpad owner should be forced to think about this problem before they use or not use third party services.

@JohnMcLear
Copy link
Member

heh

-----Original Message-----
From: ^ )> ☜(゚ヮ゚☜ [mailto:reply@reply.github.com]
Sent: 19 March 2012 21:39
To: John McLear
Subject: [etherpad-lite] optional QR code / third party service (#564)

I replaced the QR code generator link for readonly pages with this image http://memegenerator.net/instance/16615378

The QR code generator is a Google service. I think using a third party service for something should be disabled by default, but easily enabled via the config file or even configurable by making the URL a config variable. Third party services shouldnt get a hint where to find high quality information about people via readonly etherpad pages. And etherpad owner should be forced to think about this problem before they use or not use third party services.


Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/issues/564
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools

@fourplusone
Copy link
Contributor

Maybe the QR-code should go into a plugin which is not enabled by default. Why display a QR code if we can click links?

@Pita
Copy link
Contributor

Pita commented Mar 19, 2012

@0ip came up with thie QR codes afaik

@ghost ghost assigned 0ip Apr 23, 2012
@marcelklehr
Copy link
Contributor

So someone chuck out the QR-code generator code!

@JohnMcLear
Copy link
Member

@0ip - you made it, you should do the honor of pluginifying it :)

-----Original Message-----
From: Marcel Klehr [mailto:reply@reply.github.com]
Sent: 30 April 2012 10:56
To: John McLear
Subject: Re: [etherpad-lite] optional QR code / third party service (#564)

So someone chuck out the QR-code generator code!


Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/issues/564#issuecomment-5414539
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools

@0ip
Copy link
Member

0ip commented Apr 30, 2012

I wait until #627 is merged.

@0ip 0ip mentioned this issue Apr 30, 2012
@marcelklehr
Copy link
Contributor

CLOSE!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants