Button for useMonospaceFont #128

themasch · 2011-08-26T14:24:04Z

as discussed in irc. Here it is!

wscott · 2011-09-02T10:57:23Z

Not used? That is the one feature I was missing to make this useful.

Perhaps there is a config option to ALWAYS use monospace?
I did discover I can add ?useMonospacedFont=true to the URL to control this. Useful, but a bit awkward

themasch · 2011-09-02T12:11:25Z

@wscott: i absolutely second that!

ggiammat · 2011-09-02T12:14:17Z

I'm missing this feature too!

vaab · 2011-09-15T07:12:40Z

@wscott: I'm missing this feature too...

I got to the same point: using '?useMonospaceFont=true' works, but I would be glad to set this to ALWAYS use monospace.

raphaelbastide · 2011-09-24T09:37:51Z

I agree, The button should be a default checked "use monospace"

waldyrious · 2011-11-04T13:05:53Z

+1. An url parameter is useful but definitely not appropriate as an interface to toggle an option.

Wikinaut · 2011-11-17T19:41:34Z

+1 , it is a perfect patch, I have tested it. Pita: please pull this in.

Pita · 2011-11-18T22:38:48Z

@johnyma22 In my opinion we should merge this

JohnMcLear · 2011-11-19T00:07:13Z

It needs to have a setting in settings.json

-----Original Message-----
From: Peter 'Pita' Martischka [mailto:reply@reply.github.com]
Sent: 18 November 2011 22:39
To: John McLear
Subject: Re: [etherpad-lite] Button for useMonospaceFont (#128)

@johnyma22 In my opinion we should merge this

Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/pull/128#issuecomment-2795307
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools;/p>

Pita · 2011-11-19T00:52:27Z

@johnyma22 I don't agree with that. Whats your problem with the monospace button?

JohnMcLear · 2011-11-19T00:58:06Z

My users don't want it :|

I could comment in out in CSS but the use case of monocase is pretty rare.

How many people that dont use linux do you think use monospace on a daily basis?

From: Peter 'Pita' Martischka [reply@reply.github.com]
Sent: 19 November 2011 00:52
To: John McLear
Subject: Re: [etherpad-lite] Button for useMonospaceFont (#128)

@johnyma22 I don't agree with that. Whats your problem with the monospace button?

Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/pull/128#issuecomment-2796525
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools;/p>

Pita · 2011-11-19T01:36:22Z

every programmer needs it... It's not a linux thing

On 18 November 2011 16:58, John McLear
reply@reply.github.com
wrote:

My users don't want it :|

I could comment in out in CSS but the use case of monocase is pretty rare.

How many people that dont use linux do you think use monospace on a daily basis?

From: Peter 'Pita' Martischka [reply@reply.github.com]
Sent: 19 November 2011 00:52
To: John McLear
Subject: Re: [etherpad-lite] Button for useMonospaceFont (#128)

@johnyma22 I don't agree with that. Whats your problem with the monospace button?

Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/pull/128#issuecomment-2796525
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools;/p>

Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/pull/128#issuecomment-2796564

Wikinaut · 2011-11-19T09:28:07Z

For example, when you post parts of program or when you add a table.

It would be a "nice to have" to allow users to set monospace per-character like bold, italics, underline, strike-trough, and not only per-pad.

JohnMcLear · 2011-11-19T15:28:22Z

And < 1% of Etherpad users are programmers, I'm representing the 99% here, by default if a feature is only required by 1% of our user base then it shouldn't be enabled by default if it uses pixel space on the main screen.

-----Original Message-----
From: Peter 'Pita' Martischka [mailto:reply@reply.github.com]
Sent: 19 November 2011 01:36
To: John McLear
Subject: Re: [etherpad-lite] Button for useMonospaceFont (#128)

every programmer needs it... It's not a linux thing

On 18 November 2011 16:58, John McLear
reply@reply.github.com
wrote:

My users don't want it :|

I could comment in out in CSS but the use case of monocase is pretty rare.

How many people that dont use linux do you think use monospace on a daily basis?

From: Peter 'Pita' Martischka [reply@reply.github.com]
Sent: 19 November 2011 00:52
To: John McLear
Subject: Re: [etherpad-lite] Button for useMonospaceFont (#128)

@johnyma22 I don't agree with that. Whats your problem with the monospace button?

Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/pull/128#issuecomment-2796525
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools;/p>

Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/pull/128#issuecomment-2796564

Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/pull/128#issuecomment-2796793
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools;/p>

JohnMcLear · 2011-11-19T15:28:42Z

Also you can pass a parameter in the URL if you want userspace, if you say that it's useful for programmers I would like to think that programmers know how to pass a parameter via the URL ;)

-----Original Message-----
From: Peter 'Pita' Martischka [mailto:reply@reply.github.com]
Sent: 19 November 2011 01:36
To: John McLear
Subject: Re: [etherpad-lite] Button for useMonospaceFont (#128)

every programmer needs it... It's not a linux thing

On 18 November 2011 16:58, John McLear
reply@reply.github.com
wrote:

My users don't want it :|

I could comment in out in CSS but the use case of monocase is pretty rare.

How many people that dont use linux do you think use monospace on a daily basis?

From: Peter 'Pita' Martischka [reply@reply.github.com]
Sent: 19 November 2011 00:52
To: John McLear
Subject: Re: [etherpad-lite] Button for useMonospaceFont (#128)

@johnyma22 I don't agree with that. Whats your problem with the monospace button?

Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/pull/128#issuecomment-2796525
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools;/p>

Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/pull/128#issuecomment-2796564

Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/pull/128#issuecomment-2796793
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools;/p>

rspeer · 2011-11-20T04:43:58Z

Monospace is useful, especially for the kind of people who'll be running an experimental new version of EtherPad. Why not pull in the change, and then johnyma22 or whoever wants to can make the config option to hide it on certain sites?

JohnMcLear · 2011-11-20T13:55:39Z

Displaying a monospace button should be "opt in" not "opt out", I know this from gathering stats across a large number of live Etherpad sites.

This isn't just based on opinion.

If anyone else has stats that argue otherwise feel free to contribute to the discussion.

-----Original Message-----
From: Rob Speer [mailto:reply@reply.github.com]
Sent: 20 November 2011 04:44
To: John McLear
Subject: Re: [etherpad-lite] Button for useMonospaceFont (#128)

Monospace is useful, especially for the kind of people who'll be running an experimental new version of EtherPad. Why not pull in the change, and then johnyma22 or whoever wants to can make the config option to hide it on certain sites?

Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/pull/128#issuecomment-2802514
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools;/p>

crash-dive · 2011-11-20T15:10:57Z

Although I don't have any stats I am inclined to agree with johnyma22 on this. Although I can see why some people might want it, I do not think this is something the average user would need and therefore it should be off by default.

vaab · 2011-11-20T19:04:49Z

What I missed was a way to get monospace without having to change code nor change URLs. I guess that a simple configure option server side would make me happy. And this would be an "Opt in" as suggested by @johnyma2. I don't see the point of having a button in the interface as it clutters it (and I would have it alway ON while others would have it always OFF).

Wikinaut · 2011-11-21T23:56:17Z

Hello, the monospaced etherpad-lite pages are not rendered in monospace font when exported as PDF.
Can anyone fix this, too?

JohnMcLear · 2011-12-04T22:38:28Z

@Wikinaut please file a separate bug report for that

booo · 2011-12-22T02:21:41Z

This isn't part of the master branch? Could someone explain me why? I don't understand the decision making process...

For usability reason there should be a mono space button! Default for new pads should be mono spacing off.

Wikinaut · 2011-12-22T09:47:52Z

@booo

my https://github.com/Wikinaut/etherpad-lite - which follows the master's core code changes - has "monospace" integrated.

dohse · 2011-12-22T23:01:21Z

As we are running a etherpad instance for the use of mostly user with a computer science background. it would be really helpful for us to have at least the option to offer monospace font. it would a real hassle to maintain a patch for that.

i understand that you want to keep the ui clean and do not want to scare away users with to many knobs, but please offer the option for a monospace font button.

jhollinger · 2011-12-23T01:53:33Z

Maybe a monospace button would make a good plugin, if those ever get off the ground.

JohnMcLear · 2012-01-02T14:48:03Z

@booo Because the monospace button is used on < 5% of pads. Ideally it will be usable as a plugin like @jhollinger said

booo · 2012-01-02T19:56:40Z

Can you proof the < 5%?

Several users/developers requested the feature or to be more precise a button to enable/disable the feature via the gui. Adding the button to the gui is a minimal change which doesn't heard anyone. I can't see the reason why we should not implement/add this button.

I think text layout and style is a core feature of the etherpad and shouldn't be part of any plugin.

JohnMcLear · 2012-01-02T20:04:11Z

Yes

reply@reply.github.com wrote:

Can you proof the < 5%?

Several users/developers requested the feature or to be more precise a button to enable/disable the feature via the gui. Adding the button to the gui is a minimal change which doesn't heard anyone. I can't see the reason why we should not implement/add this button.

I think text layout and style is a core feature of the etherpad and shouldn't be part of any plugin.

Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/pull/128#issuecomment-3333012
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools

Wikinaut · 2012-01-02T20:26:53Z

We should perhaps make an opinion poll among the Etherpad lite developers, not the users (figures, no one can really "prove").

The addition of the monospace button is so easy, that I would rather suggest(!) to add the feature (like I did on my fork), and to have an settings.json for monospace = enabled than to have lengthy discussions.

What online tool is suited for opinion polls ?

Wikinaut · 2012-01-02T20:28:30Z

Here's the edit button bar with "monospace" and "ordered list" buttons
https://github.com/Wikinaut/etherpad-lite/blob/master/static/img/etherpad_lite_icons.png

jhollinger · 2012-01-02T21:04:30Z

While I am only partially against adding a monospace button to master, I do wonder how casually we should be adding config options to settings.json. An option to enable/disable an edit bar button (as I believe @Wikinaut is suggesting) strikes me as heading down a chaotic path. Is that just me? Don't mean to get off-topic, but it seems related.

JohnMcLear · 2012-01-02T21:27:05Z

Ask developers not users.... bad idea IMHO

Wikinaut reply@reply.github.com wrote:

We should perhaps make an opinion poll among the Etherpad lite developers, not the users (figures, no one can really "prove").

The addition of the monospace button is so easy, that I would rather suggest(!) to add the feature (like I did on my fork), and to have an settings.json for monospace = enabled than to have lengthy discussions.

What online tool is suited for opinion polls ?

Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/pull/128#issuecomment-3333278
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools

Wikinaut · 2012-01-10T23:31:36Z

I suggest a behaviour change:

not changing a whole pad to "monospace" font what the current patch does,
but on span or line basis:

mark a passage
click "monospace" button
only changing the marked passage to a fixed "monospace" font

JohnMcLear · 2012-01-27T01:05:04Z

FYI This is in the latest version. git pull people.. git pull!

added a button to toggle the font

419d2bb

Merge branch 'master' of git://github.com/Pita/etherpad-lite

9fbaddd

Merge git://github.com/Pita/etherpad-lite

3326691

JohnMcLear closed this Dec 4, 2011

snyk-bot mentioned this pull request Jun 5, 2020

[Snyk] Security upgrade npm from 3.0.0 to 6.6.0 kaystrobach/etherpad-lite#18

Open

snyk-bot mentioned this pull request Apr 16, 2021

[Snyk] Security upgrade npm from 6.4.1 to 6.6.0 sirinartk/etherpad-lite#9

Open

snyk-bot mentioned this pull request Aug 17, 2021

[Snyk] Security upgrade npm from 6.4.1 to 6.6.0 sirinartk/etherpad-lite#15

Open

snyk-bot mentioned this pull request Oct 26, 2021

[Snyk] Upgrade rate-limiter-flexible from 2.3.0 to 2.3.1 #5245

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Button for useMonospaceFont #128

Button for useMonospaceFont #128

themasch commented Aug 26, 2011

wscott commented Sep 2, 2011

themasch commented Sep 2, 2011

ggiammat commented Sep 2, 2011

vaab commented Sep 15, 2011

raphaelbastide commented Sep 24, 2011

waldyrious commented Nov 4, 2011

Wikinaut commented Nov 17, 2011

Pita commented Nov 18, 2011

JohnMcLear commented Nov 19, 2011

Pita commented Nov 19, 2011

JohnMcLear commented Nov 19, 2011

Pita commented Nov 19, 2011

Wikinaut commented Nov 19, 2011

JohnMcLear commented Nov 19, 2011

JohnMcLear commented Nov 19, 2011

rspeer commented Nov 20, 2011

JohnMcLear commented Nov 20, 2011

crash-dive commented Nov 20, 2011

vaab commented Nov 20, 2011

Wikinaut commented Nov 21, 2011

JohnMcLear commented Dec 4, 2011

booo commented Dec 22, 2011

Wikinaut commented Dec 22, 2011

dohse commented Dec 22, 2011

jhollinger commented Dec 23, 2011

JohnMcLear commented Jan 2, 2012

booo commented Jan 2, 2012

JohnMcLear commented Jan 2, 2012

Wikinaut commented Jan 2, 2012

Wikinaut commented Jan 2, 2012

jhollinger commented Jan 2, 2012

JohnMcLear commented Jan 2, 2012

Wikinaut commented Jan 10, 2012

JohnMcLear commented Jan 27, 2012

Button for useMonospaceFont #128

Button for useMonospaceFont #128

Conversation

themasch commented Aug 26, 2011

wscott commented Sep 2, 2011

themasch commented Sep 2, 2011

ggiammat commented Sep 2, 2011

vaab commented Sep 15, 2011

raphaelbastide commented Sep 24, 2011

waldyrious commented Nov 4, 2011

Wikinaut commented Nov 17, 2011

Pita commented Nov 18, 2011

JohnMcLear commented Nov 19, 2011

Pita commented Nov 19, 2011

JohnMcLear commented Nov 19, 2011

Pita commented Nov 19, 2011

Wikinaut commented Nov 19, 2011

JohnMcLear commented Nov 19, 2011

JohnMcLear commented Nov 19, 2011

rspeer commented Nov 20, 2011

JohnMcLear commented Nov 20, 2011

crash-dive commented Nov 20, 2011

vaab commented Nov 20, 2011

Wikinaut commented Nov 21, 2011

JohnMcLear commented Dec 4, 2011

booo commented Dec 22, 2011

Wikinaut commented Dec 22, 2011

dohse commented Dec 22, 2011

jhollinger commented Dec 23, 2011

JohnMcLear commented Jan 2, 2012

booo commented Jan 2, 2012

JohnMcLear commented Jan 2, 2012

Wikinaut commented Jan 2, 2012

Wikinaut commented Jan 2, 2012

jhollinger commented Jan 2, 2012

JohnMcLear commented Jan 2, 2012

Wikinaut commented Jan 10, 2012

JohnMcLear commented Jan 27, 2012