Allow for a setting so you can stop unknown file types from being imported #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnMcLear
changed the title
JohnMcLear
added a commit
that referenced
this pull request
Nov 15, 2014
…e-types Allow for a setting so you can stop unknown file types from being imported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior: Any file type can be imported, if it's unknown it is converted to .txt
With this setting: By default normal behavior is persistent however adding setting (as per template file) stops these files from being imported and shows error to user.
Should be pretty obvious what it does and how it works. Don't think we need docs as the docs are in the template file.
It would be nice in the future to allow for an array of supported file types to be passed but that's a job for the future once this is in and mature.