Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing travis ci sauce labs - Ready for Review / Merge @muxator #3743

Merged
merged 4 commits into from
Mar 23, 2020
Merged

Testing travis ci sauce labs - Ready for Review / Merge @muxator #3743

merged 4 commits into from
Mar 23, 2020

Conversation

JohnMcLear
Copy link
Member

@JohnMcLear JohnMcLear commented Mar 22, 2020 •
edited
Loading

Suggest doing a squash when merging.

Intentionally commited to ether repo.

  • SC latest reference file 404'd. Used explicit sauce labs version file.
  • Attempt to remove wd (this can't be removed)
  • Make sure this works for @muxator and @lpagliari -- Okay so Travis runs the tests and these settings are set in Travis - SAUCE_ACCESS_KEY / SAUCE_USERNAME -- Email sent to @muxator with credentials
  • Check SL is running OS' we want (See changes to remote_runner.js and now we have more coverage! This was a nightmare to do(and took hours) though because saucelabs OS / platform / browser names don't match what's required in their own docs [platform configuration tool] for some reason...) -- I tried to make this future oriented with using 'latest' where possible.
  • Make tests that have been broken pass. I'm not fixing tests that fail due to colibris tho.
  • Understand if tests pass who and how the results are passed - Afaik it returns all tests passed even if some tests fail?! <-- I suggest merging and doing this as an additional task. The reason being is that until things are in develop it's hard to go between a working / broken state.

@JohnMcLear
tests: configure the OS/Browsers versions on which tests will be run
9558f1e 
For all the supported operating systems, the latest version of each browser is
supported, with the Exception of Win 8 / IE 10, which has an explicit version
pinned.
@JohnMcLear
tests: enable sauce labs tests again
d1f3cd6
@JohnMcLear JohnMcLear changed the title Testing travis ci sauce labs Testing travis ci sauce labs - Ready for Review / Merge @muxator Mar 23, 2020
@muxator muxator self-requested a review March 23, 2020 20:55
@muxator muxator added the tests label Mar 23, 2020
@muxator muxator mentioned this pull request Mar 23, 2020
Merged
3 tasks
@muxator muxator force-pushed the testing-travis-ci-sauce-labs branch from fcce3c1 to 724e85a Compare March 23, 2020 21:45
@muxator muxator force-pushed the testing-travis-ci-sauce-labs branch from 724e85a to d1f3cd6 Compare March 23, 2020 22:08
muxator
muxator reviewed Mar 23, 2020
View reviewed changes
tests/frontend/travis/remote_runner.js
, 'browserName' : 'iexplore'
, 'version' : '9'
, 'version' : '10.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it work if we put IE 11 here? I know it took a lot of time to find these combinations.

IE 10 is practically out of support.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intentionally chose IE10 and Edge to get opposite ends of the spectrum from MS. You could bring another blob in for IE11 should you wish. We're supposed to have 5 concurrent tests run but afaik it only does 4(saucelabs is weird) so it wouldn't slow things down at all..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine. Let's keep IE 10.

muxator
muxator reviewed Mar 23, 2020
View reviewed changes
Copy link
Contributor

@muxator muxator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, my only doubt is if we would try to use IE 11 instead of IE 10. But I do not know if Saucelabs would accept it.

@muxator muxator merged commit 61f0b5d into develop Mar 23, 2020
@muxator muxator deleted the testing-travis-ci-sauce-labs branch March 23, 2020 22:52
@muxator
Copy link
Contributor

muxator commented Mar 23, 2020 •
edited
Loading

Pulled in, thanks for the hard work.

Please note that I have deleted the original testing-travis-ci-sauce-labs in the main repo. A re-clone will be advisable, see #3745 (comment).

@JohnMcLear
Copy link
Member Author

Ack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muxator muxator muxator left review comments

Assignees

@JohnMcLear JohnMcLear

Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnMcLear @muxator