bin/safeRun.sh: Fix try: not found bug
#4935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a copy+paste bug introduced in commit 8b28e00 (v1.8.8).
ldidry
reviewed
Mar 10, 2021
| MY_DIR=$(try cd "${0%/*}" && try pwd -P) || exit 1 | ||
| try cd "${MY_DIR}/../.." | ||
| MY_DIR=$(cd "${0%/*}" && pwd -P) || exit 1 | ||
| cd "${MY_DIR}/../.." || exit 1 |
There was a problem hiding this comment.
Suggested change
| cd "${MY_DIR}/../.." || exit 1 | |
| cd "${MY_DIR}/../.." || fatal "Couldn't go to ${MY_DIR}/../.." |
There was a problem hiding this comment.
Otherwise, looks good to me. Thanks!
There was a problem hiding this comment.
I'd rather define try in this file than use fatal. I'm doing neither to fix this bug because I prefer consistency with the other scripts in this same directory. (That cd should never fail anyway.)
|
Thanks for the bug report and the review @ldidry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a copy+paste bug introduced in commit 8b28e00 (v1.8.8).
Fixes #4930.
cc @ldidry