Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACE2 refactoring #599

Merged
merged 17 commits into from
Apr 7, 2012
Merged

ACE2 refactoring #599

merged 17 commits into from
Apr 7, 2012

Conversation

fourplusone
Copy link
Contributor

This pull request introduces 2 new modules

  • ChangesetUtils.js, basically code from ace2_inner.js moved into it's own module
  • AttributeManager.js, a class which manages the attributes of the text (unfinished, since some code is still in ace2_inner.js)

+ several minor (code style) improvements

@yadutaf
Copy link

yadutaf commented Apr 5, 2012

This is a great start. We need that in. Can you add a documentation block above your functions and at the top of the file ? Later we will need to refqctor the equivalent for range styles.

@fourplusone
Copy link
Contributor Author

Just push'd some more docs + moving performDocumentApplyAttributesToRange to AttributeManager.setAttributesOnRange

JohnMcLear added a commit that referenced this pull request Apr 7, 2012
@JohnMcLear JohnMcLear merged commit 57e137f into ether:develop Apr 7, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants