Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/v3 i18n support #438

Open
wants to merge 12 commits into
base: v3-dev
Choose a base branch
from

Conversation

therealpecus
Copy link
Contributor

Fixes #437 .

Changes proposed in this pull request:

  • use Craft t() filter for static message translation in all templates
  • move JS strings to a twig template to support static message translation
  • adopt Fixing #405 & #406: Remove version number #411
  • use Craft.asciiCharMap for diacritic normalization
  • update Twig namespaces removing deprecations

Notes:

I am currently working with Craft 3.5.x so I added support for full i18n of the plugin to the v3 version. This work is easily portable to v4 due to the plugin being virtually identical in templates and static strings. I can open a separate issue and PR if this one goes through.

This PR benefits from a commit squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant