-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Filecoin networks. #1567
add Filecoin networks. #1567
Conversation
@ligi any chance we could get a review here? 🙏 |
_data/chains/eip155-314.json
Outdated
"name": "Filecoin — Mainnet", | ||
"chain": "FIL", | ||
"status": "incubating", | ||
"rpc": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For rpc we can add:
"rpc" [
"https://api.node.glif.io/rpc/v0"
].
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I was under the impression that these RPCs needed to follow the Ethereum JSON-RPC interface, hence why I left them blank while that implementation is underway. Happy to add these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Can leave it blank for now, this is for EVM flavoured chains only, while the rest of CAIP is setting the standards on a per chain basis for things like wallet clients that want to talk across them.
_data/chains/eip155-31415.json
Outdated
"name": "Filecoin — Wallaby testnet", | ||
"chain": "FIL", | ||
"status": "incubating", | ||
"rpc": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For rpc we can add:
"rpc" [
"https://wallaby.node.glif.io/rpc/v0"
].
_data/chains/eip155-314159.json
Outdated
"name": "Filecoin — Calibration testnet", | ||
"chain": "FIL", | ||
"status": "incubating", | ||
"rpc": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For rpc we can add:
"rpc" [
"https://api.calibration.node.glif.io/rpc/v0"
].
"decimals": 18 | ||
}, | ||
"infoURL": "https://filecoin.io", | ||
"shortName": "filecoin", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't it
shortname: "fil",
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've never seen the Filecoin network addressed as purely "fil", or "fil network".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just basing this on https://github.com/ethereum-lists/chains/blob/master/_data/chains/eip155-1.json#L18 but can ask Boris about this tomorrow
13b06cb
to
4fa8ff0
Compare
Please merge together with #1590 |
I think all requested changes have been applied now. |
* fip-0039: update chain ids ref: ethereum-lists/chains#1567 * fix fip number in references * remove chainid considerations from fip-0039
The Filecoin team at Protocol Labs shipped the Filecoin Virtual Machine to mainnet in July 2022, during the Skyr network upgrade.
Since then, we've been working on the first user-programmable execution runtime, called FEVM (Filecoin EVM). It will be fully compatible with Ethereum tooling. For this reason, we would like to allocate chain IDs for all Filecoin networks, including:
Full project roadmap here.