Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed accounts.controller test for Merkle tree hash algh #756

Conversation

djanluka
Copy link
Contributor

Description

Fixed test for account controller with extracted var for merkle tree hash algh

Related issues

SRI - Extract 'sha256' as hash algh used for the merke trees to env #743

@@ -38,6 +38,10 @@ describe('AccountController', () => {
let subjectAccountStorageAgentMock: DeepMockProxy<BpiSubjectAccountStorageAgent>;
let merkleTreeStorageAgentMock: DeepMockProxy<MerkleTreeStorageAgent>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this can be removed.

@@ -38,6 +38,10 @@ describe('AccountController', () => {
let subjectAccountStorageAgentMock: DeepMockProxy<BpiSubjectAccountStorageAgent>;
let merkleTreeStorageAgentMock: DeepMockProxy<MerkleTreeStorageAgent>;

beforeAll(async () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me as a band-aid. Testing should likely have its own config file/files that set these variables among others. I believe this work has already begun in builders.ts and testData.helper.ts

@ognjenkurtic ognjenkurtic merged commit 67e87a5 into ethereum-oasis-op:main Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants