-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/761 build and e2e test ci #768
Feature/761 build and e2e test ci #768
Conversation
e2e test run logs this: Failed execution of transaction with id 1141cc17-3d96-4cc4-aecb-50e8e4d557ec. Error: NotImplementedException: Not Implemented It is because we are invoking storeAnchorHashOnCcsm in the ExecuteVsmCycleCommandHandler. The test is still green though, i suspect we are not asserting everything we should assert. Could you please open an issue to resolve it separately? |
..and timeout is there to wait for one execution cycle to pass. Open for a better approach. |
yea i assumed you are aware of this and it is some tmp not implemented thing, as this is also showing locally, i will open separate issue for that regarding timeout, i understand why its there, but jest sees it as some handler that is hanging, and after tests are green, jest hangs with message that there is something not closed, and i identified it is that part, so i added --forceExit so github worklow doesnt hang but i will include this in that separate issue i open, for now i dont think it should block merge of this PR. what do you think? |
@ognjenkurtic can you please review Skos' comment to unblock this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add build and e2e steps to workflow.
Force exit on e2e tests because jest detects this part as open handle:
I think using
--forceExit
flag is ok here.Also, I used public goerli rpc url for
GOERLI_RPC_URL
env var in workflow, probably better than hiding infura url, as we probably won't get rate limited. The rest of env vars i just copied from.env.sample
since that is already in the repo.Related Issue
#761
Motivation and Context
To make PR process more robust.
How Has This Been Tested
I tested on my fork.
Screenshots (if appropriate)
Types of changes
Checklist